Closed Bug 1107969 Opened 10 years ago Closed 8 years ago

Intermittent browser_restore_isAppTab.js | A promise chain failed to handle a rejection: - at resource://gre/modules/PageThumbs.jsm:306 - Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMessageSender.sendAsyncMessage]

Categories

(Firefox :: Session Restore, defect, P3)

Product:
Firefox
Component:
Session Restore
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: RyanVM, Assigned: mikedeboer)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1107969 - don't take content screenshots when the message manager has shut down.
58 bytes, text/x-review-board-request
mconley
: review+
jcristau
: approval-mozilla-aurora+
gchang
: approval-mozilla-beta+
Details 
09:36:30 INFO - ###!!! [Parent][MessageChannel] Error: Channel error: cannot send/recv

<and a lot more like that ^^^>

09:36:31 INFO - Xlib: extension "RANDR" missing on display ":0".
09:36:31 INFO - JavaScript warning: chrome://specialpowers/content/specialpowers.js, line 27: JavaScript 1.7's let blocks are deprecated
09:36:31 INFO - 334 INFO checking window state
09:36:31 INFO - 335 INFO Entering test navigate
09:36:31 INFO - 336 INFO Waiting for browser load
09:36:31 INFO - 337 INFO Saw state c0010 and status 0
09:36:31 INFO - 338 INFO Browser loaded about:robots
09:36:31 INFO - 339 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Docshell shouldn't think it is an app tab
09:36:31 INFO - 340 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Docshell should think it is an app tab
09:36:31 INFO - 341 INFO Waiting for browser load
09:36:31 INFO - 342 INFO Saw state f0001 and status 0
09:36:31 INFO - 343 INFO Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/browser/base/content/test/general/dummy_page.html" line: 0}]
09:36:31 INFO - 344 INFO Saw state c0010 and status 0
09:36:31 INFO - 345 INFO Browser loaded http://example.com/browser/browser/base/content/test/general/dummy_page.html
09:36:31 INFO - 346 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Docshell should think it is an app tab
09:36:31 INFO - 347 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Docshell shouldn't think it is an app tab
09:36:31 INFO - 348 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Docshell should think it is an app tab
09:36:31 INFO - 349 INFO Waiting for browser load
09:36:31 INFO - 350 INFO Saw state f0001 and status 0
09:36:31 INFO - 351 INFO Saw state c0010 and status 0
09:36:31 INFO - 352 INFO Browser loaded about:robots
09:36:31 INFO - 353 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Docshell should think it is an app tab
09:36:31 INFO - 354 INFO Leaving test navigate
09:36:31 INFO - 355 INFO Entering test crash
09:36:31 INFO - 356 INFO Waiting for browser load
09:36:31 INFO - 357 INFO Saw state f0001 and status 0
09:36:31 INFO - 358 INFO Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.com/browser/browser/base/content/test/general/dummy_page.html" line: 0}]
09:36:31 INFO - 359 INFO Saw state c0010 and status 0
09:36:31 INFO - 360 INFO Browser loaded http://example.com/browser/browser/base/content/test/general/dummy_page.html
09:36:31 INFO - 361 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Docshell shouldn't think it is an app tab
09:36:31 INFO - 362 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Docshell should think it is an app tab
09:36:31 INFO - 363 INFO Waiting for AboutTabCrashedLoad
09:36:31 INFO - 364 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Received correct observer topic.
09:36:31 INFO - 365 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | Subject implements nsIPropertyBag2.
09:36:31 INFO - 366 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | dumpID is present and not an empty string
09:36:31 INFO - 367 INFO Console message: [JavaScript Error: "remote browser crashed while on http://example.com/browser/browser/base/content/test/general/dummy_page.html
09:36:31 INFO - " {file: "chrome://mochikit/content/mochitest-e10s-utils.js" line: 8}]
09:36:31 INFO - 368 INFO Console message: [JavaScript Error: "remote browser crashed while on http://example.com/browser/browser/base/content/test/general/dummy_page.html
09:36:31 INFO - " {file: "chrome://mochikit/content/mochitest-e10s-utils.js" line: 8}]
09:36:31 INFO - 369 INFO Saw AboutTabCrashedLoad
09:36:31 INFO - 370 INFO Wait tab event: load
09:36:31 INFO - 371 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | A promise chain failed to handle a rejection: - at resource://gre/modules/PageThumbs.jsm:306 - Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMessageSender.sendAsyncMessage]
09:36:31 INFO - Stack trace:
09:36:31 INFO - JS frame :: resource://gre/modules/PageThumbs.jsm :: this.PageThumbs._captureRemoteThumbnail :: line 306
09:36:31 INFO - JS frame :: resource://gre/modules/PageThumbs.jsm :: this.PageThumbs._captureToCanvas/< :: line 221
09:36:31 INFO - JS frame :: self-hosted :: next :: line 943
09:36:31 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 330
09:36:31 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl :: line 275
09:36:31 INFO - JS frame :: resource://gre/modules/Task.jsm :: createAsyncFunction/asyncFunction :: line 249
09:36:31 INFO - JS frame :: resource://gre/modules/Task.jsm :: Task_spawn :: line 164
09:36:31 INFO - JS frame :: resource://gre/modules/PageThumbs.jsm :: this.PageThumbs._captureToCanvas :: line 219
09:36:31 INFO - JS frame :: resource://gre/modules/PageThumbs.jsm :: PageThumbs_captureToCanvas :: line 205
09:36:31 INFO - JS frame :: chrome://browser/content/browser.js :: tabPreviews_capture :: line 6188
09:36:31 INFO - JS frame :: chrome://browser/content/browser.js :: tabPreviews_handleEvent/< :: line 6208
09:36:31 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
09:36:32 INFO - 372 INFO TEST-OK | chrome://mochitests/content/browser/browser/base/content/test/general/browser_restore_isAppTab.js | took 4099ms
Inactive; closing (see bug 1180138).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Most recent failures are linux64-debug and e10s. Logs are a little different from the original report:

https://public-artifacts.taskcluster.net/cJa08PlISdabNAD-Cwo-kQ/0/public/logs/live_backing.log

[task 2016-11-15T15:42:50.281742Z] 15:42:50     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_restore_isAppTab.js | uncaught exception - NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMessageSender.sendAsyncMessage] at this.PageThumbs.shouldStoreThumbnail@resource://gre/modules/PageThumbs.jsm:258:7
[task 2016-11-15T15:42:50.283195Z] 15:42:50     INFO - Thumbnails_shouldCapture@chrome://browser/content/browser-thumbnails.js:124:5
[task 2016-11-15T15:42:50.284739Z] 15:42:50     INFO - Thumbnails_capture@chrome://browser/content/browser-thumbnails.js:97:5
[task 2016-11-15T15:42:50.286184Z] 15:42:50     INFO - Thumbnails_delayedCapture/timeout<@chrome://browser/content/browser-thumbnails.js:112:7
[task 2016-11-15T15:42:50.287680Z] 15:42:50     INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:625:12
[task 2016-11-15T15:42:50.289421Z] 15:42:50     INFO - Thumbnails_delayedCapture@chrome://browser/content/browser-thumbnails.js:110:19
[task 2016-11-15T15:42:50.292909Z] 15:42:50     INFO - Thumbnails_onStateChange@chrome://browser/content/browser-thumbnails.js:90:7
[task 2016-11-15T15:42:50.295175Z] 15:42:50     INFO - callListeners@chrome://browser/content/tabbrowser.xml:506:24
[task 2016-11-15T15:42:50.296609Z] 15:42:50     INFO - _callProgressListeners@chrome://browser/content/tabbrowser.xml:527:13
[task 2016-11-15T15:42:50.298244Z] 15:42:50     INFO - mTabProgressListener/<._callProgressListeners@chrome://browser/content/tabbrowser.xml:576:22
[task 2016-11-15T15:42:50.299994Z] 15:42:50     INFO - mTabProgressListener/<.onStateChange@chrome://browser/content/tabbrowser.xml:745:15
[task 2016-11-15T15:42:50.301757Z] 15:42:50     INFO - RemoteWebProgressManager.prototype._callProgressListeners@resource://gre/modules/RemoteWebProgress.jsm:176:11
[task 2016-11-15T15:42:50.306479Z] 15:42:50     INFO - RemoteWebProgressManager.prototype.receiveMessage@resource://gre/modules/RemoteWebProgress.jsm:237:7
[task 2016-11-15T15:42:50.307816Z] 15:42:50     INFO - 
[task 2016-11-15T15:42:50.309305Z] 15:42:50     INFO - Stack trace:
[task 2016-11-15T15:42:50.310886Z] 15:42:50     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1583
[task 2016-11-15T15:42:50.312849Z] 15:42:50     INFO - JavaScript error: resource://gre/modules/PageThumbs.jsm, line 258: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMessageSender.sendAsyncMessage]
[task 2016-11-15T15:42:50.316784Z] 15:42:50     INFO - ###!!! [Parent][MessageChannel] Error: (msgtype=0x2C0085,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv
[task 2016-11-15T15:42:50.318412Z] 15:42:50     INFO - ++DOCSHELL 0x7f4ec0eca000 == 11 [pid = 1270] [id = 320]
[task 2016-11-15T15:42:50.320372Z] 15:42:50     INFO - ++DOMWINDOW == 23 (0x7f4ec0ecf800) [pid = 1270] [serial = 770] [outer = (nil)]
[task 2016-11-15T15:42:50.322624Z] 15:42:50     INFO - ++DOMWINDOW == 24 (0x7f4ec1483000) [pid = 1270] [serial = 771] [outer = 0x7f4ec0ecf800]

:jimm - It looks like you might be familiar with shouldStoreThumbnail...could you have a look?
Flags: needinfo?(jmathies)
Assignee: nobody → mdeboer
Status: REOPENED → ASSIGNED
Flags: needinfo?(jmathies)
Comment on attachment 8818298 [details]
Bug 1107969 - don't take content screenshots when the message manager has shut down.

https://reviewboard.mozilla.org/r/98384/#review98698

Makes sense to me! Thanks!
Attachment #8818298 - Flags: review?(mconley) → review+
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e4a2f72702f
don't take content screenshots when the message manager has shut down. r=mconley
https://hg.mozilla.org/mozilla-central/rev/9e4a2f72702f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago → 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Please request Aurora/Beta approval on this when you get a chance.
Flags: needinfo?(mdeboer)
Comment on attachment 8818298 [details]
Bug 1107969 - don't take content screenshots when the message manager has shut down.

Approval Request Comment
[Feature/Bug causing the regression]: No bug.
[User impact if declined]: Fixes frequent intermittent failure.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: ESR, perhaps.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: n/a.
[String changes made/needed]: n/a.
Flags: needinfo?(mdeboer)
Attachment #8818298 - Flags: approval-mozilla-beta?
Attachment #8818298 - Flags: approval-mozilla-aurora?
Comment on attachment 8818298 [details]
Bug 1107969 - don't take content screenshots when the message manager has shut down.

fix an intermittent test failure in aurora52
Attachment #8818298 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8818298 [details]
Bug 1107969 - don't take content screenshots when the message manager has shut down.

Fix an intermittent-failure. Beta51+. Should be in 51 beta 9.
Attachment #8818298 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: