Closed
Bug 1107972
Opened 9 years ago
Closed 9 years ago
The profiler tree looks bad after the new theme changes
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox36 fixed, firefox37 fixed)
RESOLVED
FIXED
Firefox 37
People
(Reporter: vporof, Assigned: bgrins)
References
Details
Attachments
(2 files, 1 obsolete file)
168.79 KB,
image/png
|
Details | |
3.78 KB,
patch
|
vporof
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Brian, can you take a look at this?
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 1•9 years ago
|
||
(In reply to Victor Porof [:vporof][:vp] from comment #0) > Created attachment 8532581 [details] > Screen Shot 2014-12-05 at 1.27.17 PM.png > > Brian, can you take a look at this? Sure
Blocks: 1102369
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 2•9 years ago
|
||
Please have a look, I think this will help
Assignee | ||
Comment 3•9 years ago
|
||
Swapped two of the variables that were mixed up
Attachment #8532596 -
Attachment is obsolete: true
Attachment #8532596 -
Flags: review?(vporof)
Attachment #8532597 -
Flags: review?(vporof)
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8532597 [details] [diff] [review] profiler-fix.patch Ugh, I think I was actually right with the first patch
Attachment #8532597 -
Attachment is obsolete: true
Attachment #8532597 -
Flags: review?(vporof)
Assignee | ||
Updated•9 years ago
|
Attachment #8532596 -
Attachment is obsolete: false
Attachment #8532596 -
Flags: review?(vporof)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8532597 [details] [diff] [review] profiler-fix.patch Review of attachment 8532597 [details] [diff] [review]: ----------------------------------------------------------------- Great success.
Attachment #8532597 -
Flags: review+
Assignee | ||
Comment 6•9 years ago
|
||
Did you mean to r+ the other one? I think the obsolete one has the --focus-cell-border-color mixed up
Flags: needinfo?(vporof)
Reporter | ||
Updated•9 years ago
|
Attachment #8532596 -
Flags: review?(vporof) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/960a122d7a32
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/960a122d7a32
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8532596 [details] [diff] [review] profiler-fix.patch Approval Request Comment [Feature/regressing bug #]: 1102369 [User impact if declined]: The profile tree in devtools will have some bad styling [Describe test coverage new/current, TBPL]: CSS only, no test [Risks and why]: low, it's css only and affects the profile tab in devtools only [String/UUID change made/needed]: none
Attachment #8532596 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8532596 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•