Closed Bug 1107972 Opened 9 years ago Closed 9 years ago

The profiler tree looks bad after the new theme changes

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(firefox36 fixed, firefox37 fixed)

RESOLVED FIXED
Firefox 37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: vporof, Assigned: bgrins)

References

Details

Attachments

(2 files, 1 obsolete file)

Brian, can you take a look at this?
Flags: needinfo?(bgrinstead)
(In reply to Victor Porof [:vporof][:vp] from comment #0)
> Created attachment 8532581 [details]
> Screen Shot 2014-12-05 at 1.27.17 PM.png
> 
> Brian, can you take a look at this?

Sure
Blocks: 1102369
Flags: needinfo?(bgrinstead)
Please have a look, I think this will help
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8532596 - Flags: review?(vporof)
Attached patch profiler-fix.patch (obsolete) — Splinter Review
Swapped two of the variables that were mixed up
Attachment #8532596 - Attachment is obsolete: true
Attachment #8532596 - Flags: review?(vporof)
Attachment #8532597 - Flags: review?(vporof)
Comment on attachment 8532597 [details] [diff] [review]
profiler-fix.patch

Ugh, I think I was actually right with the first patch
Attachment #8532597 - Attachment is obsolete: true
Attachment #8532597 - Flags: review?(vporof)
Attachment #8532596 - Attachment is obsolete: false
Attachment #8532596 - Flags: review?(vporof)
Comment on attachment 8532597 [details] [diff] [review]
profiler-fix.patch

Review of attachment 8532597 [details] [diff] [review]:
-----------------------------------------------------------------

Great success.
Attachment #8532597 - Flags: review+
Did you mean to r+ the other one?  I think the obsolete one has the --focus-cell-border-color mixed up
Flags: needinfo?(vporof)
Attachment #8532596 - Flags: review?(vporof) → review+
Ugh.
Flags: needinfo?(vporof)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/960a122d7a32
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment on attachment 8532596 [details] [diff] [review]
profiler-fix.patch

Approval Request Comment
[Feature/regressing bug #]: 1102369
[User impact if declined]: The profile tree in devtools will have some bad styling
[Describe test coverage new/current, TBPL]: CSS only, no test
[Risks and why]: low, it's css only and affects the profile tab in devtools only
[String/UUID change made/needed]: none
Attachment #8532596 - Flags: approval-mozilla-aurora?
Attachment #8532596 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.