Calendar should not use images for text

VERIFIED FIXED

Status

Calendar
Sunbird Only
--
minor
VERIFIED FIXED
16 years ago
11 years ago

People

(Reporter: Biesinger, Assigned: Colin Phillips)

Tracking

Details

Attachments

(3 attachments, 1 obsolete attachment)

Currently, some texts, e.g. day names, are displayed using images.
Besides using more space than simply text, this prevents localization of the texts.

Updated

16 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

16 years ago
I'll take this one
Assignee: mikep → colinp
Status: ASSIGNED → NEW

Comment 2

16 years ago
Created attachment 58413 [details]
Added entities to represent names of days

This patch is one of 3

Comment 3

16 years ago
Created attachment 58414 [details] [diff] [review]
Created grid view to display day names

Comment 4

16 years ago
Created attachment 58415 [details] [diff] [review]
added new class to stylesheet, probably not used though

Comment 5

16 years ago
Created attachment 58416 [details] [diff] [review]
added entities to represent names of days

Obsoletes attachment 58413 [details]
(Assignee)

Updated

16 years ago
Attachment #58413 - Attachment is obsolete: true
(Assignee)

Comment 6

16 years ago
Tweaked the patches a little (to remove a bunch of unecessary classes after the
patch was made) and applied (fixed in CVS).  Any more localization patches would
be great.  :)
Status: NEW → ASSIGNED
Hm, week view looks as if it would still use the images.
Oh, it only looks like that.

The images are still in CVS though, they should be removed.

And isn't calendar.monthview.column.1.name (and the following) in calendar.dtd a
duplication of day.1.DDD in penglobal/global.dtd ?
(Assignee)

Comment 9

16 years ago
ok, I removed the images in cvs.

And yes, the two dtd values are the same, but the dtd's belong to different
portions of code.  Would it be wise to combine the two?
(Assignee)

Comment 10

16 years ago
Ok, the only images for text I know of that are left are the days of the week in
the datepicker.  Does anyone see any others?
(Assignee)

Comment 11

16 years ago
mike, we can (potentially) close this bug if we can get that datepicker xbl
working.  See last comment before this one.
(Assignee)

Comment 12

16 years ago
I checked in the last fix to this bug.  The datepicker now uses DTD's and CSS to
show the SUN/MON/TUE... strip.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
vrfy, no image contains text anymore.
Status: RESOLVED → VERIFIED
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: colint → sunbird
You need to log in before you can comment on or make changes to this bug.