110803 - Calendar should not use images for text

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Currently, some texts, e.g. day names, are displayed using images.
Besides using more space than simply text, this prevents localization of the texts.

Comment 1

[Colin Phillips]

I'll take this one

Comment 2

[John R. Hicks]

Attachment: Added entities to represent names of days

This patch is one of 3

Comment 3

[John R. Hicks]

Attachment: Created grid view to display day names

Comment 4

[John R. Hicks]

Attachment: added new class to stylesheet, probably not used though

Comment 5

[John R. Hicks]

Attachment: added entities to represent names of days

Obsoletes attachment 58413 [details]

Comment 6

[Colin Phillips]

Tweaked the patches a little (to remove a bunch of unecessary classes after the
patch was made) and applied (fixed in CVS).  Any more localization patches would
be great.  :)

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Hm, week view looks as if it would still use the images.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Oh, it only looks like that.

The images are still in CVS though, they should be removed.

And isn't calendar.monthview.column.1.name (and the following) in calendar.dtd a
duplication of day.1.DDD in penglobal/global.dtd ?

Comment 9

[Colin Phillips]

ok, I removed the images in cvs.

And yes, the two dtd values are the same, but the dtd's belong to different
portions of code.  Would it be wise to combine the two?

Comment 10

[Colin Phillips]

Ok, the only images for text I know of that are left are the days of the week in
the datepicker.  Does anyone see any others?

Comment 11

[Colin Phillips]

mike, we can (potentially) close this bug if we can get that datepicker xbl
working.  See last comment before this one.

Comment 12

[Colin Phillips]

I checked in the last fix to this bug.  The datepicker now uses DTD's and CSS to
show the SUN/MON/TUE... strip.

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

vrfy, no image contains text anymore.

Comment 14

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!