1108037 - Unable to access Firefox Hello controls with tabs set on right side using Tree Style Tab add-on

Status: RESOLVED INVALID

(Hello (Loop) :: Client, defect, P2)

Description

[vijay krishna m]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20141201162954

Steps to reproduce:

1. Create a new profile and install Tree Style Tab add-on (https://addons.mozilla.org/en-US/firefox/addon/tree-style-tab/?src=ss)
2. Change preferences to set tabs on right side of screen.
3. Click on Hello button, start a conversation button and click on the link.


Actual results:

I am unable to access any of the controls on the conversation pop up window.


Expected results:

I should be able to access controls on the pop up window.

Comment 1

[u279076]

Attachment: Screen Shot 2014-12-09 at 9.31.50 AM.png

Confirmed reproducible - here is a screenshot that shows the issue.

Comment 2

[u279076]

Thanks for filing this bug report, Vijay.

I'm nominating this to block 35 given that Tree Style Tab tends to peak at ~105K users week over week. I'll also forward this issue to the addon developer.

Comment 3

[Maire Reavy [:mreavy]]

I'd love to fix this in Fx35.  I'm not sure how easy it is (or if the fix needs to be in our code or the add-on).

Comment 4

[Mark Banner (:standard8)]

Ok, I think there's potentially two issues here:

1) Even without the add-on, if you make the browser small/short enough, then the tabs overlay the chat window. Not sure if this is by design or not (one could argue it is I guess).

2) With the add-on in right-hand side mode, I think the add-on should be forcing the chat-bar (where Social's and Loop's chats appear) to have the right-side aligned with the left-side of the new tab bar.

IMO This second step would provide a better UX for the add-on even if 1) was fixed.


Shane might have some context here as well, so ni to him.

Comment 5

[Maire Reavy [:mreavy]]

I'd love to see this fixed in Fx35, but we won't block the release for this.

Comment 6

[Shane Caraveo (:mixedpuppy)]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #5)
> I'd love to see this fixed in Fx35, but we won't block the release for this.

This is a fix the addon needs to do, not us.  The addon author needs to add margin to the chatbar so it doesn't overlay the tabs.

Comment 7

[Shane Caraveo (:mixedpuppy)]

Specifically the addon needs to update the css for chatbar in browser.xul:

#pinnedchats {
  -moz-margin-start: ???px
}

Where the value is the width of the tab panel plus some.  When the user resizes the tab panel (wider or narrower) the value has to be updated.  Not sure if there is some css calculation that could be done here.

Comment 8

[Mark Banner (:standard8)]

I've commented with some information on the github issue for the add-on here:

https://github.com/piroor/treestyletab/issues/753

Comment 9

[Maire Reavy [:mreavy]]

Shane -- Is there any value in keeping this bug open and perhaps moving it to another bugzilla component -- or should we just close this as invalid?  (Standard8 and I were just debating if keeping this bug open and re-purposing it has any value.)

Comment 10

[Shane Caraveo (:mixedpuppy)]

Bugs are cheap, lets just close it.