110807 - footprint: get trace-malloc tools to work with windows mozilla trace-malloc output

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Garrett Arch Blythe]

The subject really says it all.

What we have today is a windows mozilla outputing trace-malloc data, but tools
in mozilla/tools/trace-malloc unable to read the data, likely due to the magic
number \n conversion at the beginning of the file.

After I get this done, then I need to update the SpaceTrace HOWTO with build
instructions for windows.

Futher, this bug is not to FIX trace-malloc call stacks on windows, but simply
to get the tools to be able to read the trace-malloc output on windows.

Comment 1

[Garrett Arch Blythe]

Attachment: Read as binary on WIN32

Comment 2

[Garrett Arch Blythe]

request review, not part of normal build

Cathleen, do I need review for this?  If so, can you get a couple of
trace-malloc people to do it?

Comment 3

[Cathleen]

brendan and dbaron, can you guys review?  -thx!!

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 58594 [details] [diff] [review]
Read as binary on WIN32

r=dbaron

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 58594 [details] [diff] [review]
Read as binary on WIN32

Nit: non-conforming comment style whine.

+	     /*
+	     ** Avoid translations on WIN32.
+	     */

sr=[e-mail]

/be

Comment 6

[Garrett Arch Blythe]

checked in, changed comment style ;)