1108168 - nsSearchService's getBoolPref triggers exceptions (and catches them), which is noisy for debuggers

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Alex Vincent [:WeirdAl]]

Attachment: nsSearchService.js

Our company's XUL app, run with firefox --app, doesn't have a lot of search preferences defined.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 8532744 [details] [diff] [review]
nsSearchService.js

> function getBoolPref(aName, aDefault) {
>+  if (Services.prefs.getPrefType(aName) != Ci.nsIPrefBranch.PREF_BOOL)
>+    return aName;
>   try {
>     return Services.prefs.getBoolPref(aName);
>   } catch (ex) {
>     return aDefault;
>   }
> }

Returning aName doesn't seem to make any sense. Also, with this check added, the try/catch can go away, right?

Comment 2

[Alex Vincent [:WeirdAl]]

Whoops, I clearly meant aDefault!  Yes, the try... catch can go away.

Comment 3

[Alex Vincent [:WeirdAl]]

Attachment: nsSearchService.js.diff

Comment 4

[Alex Vincent [:WeirdAl]]

Comment on attachment 8533306 [details] [diff] [review]
nsSearchService.js.diff

I presume the code for search is fairly well tested...

Comment 5

[Carsten Book [:Tomcat]]

can we get a try run for this change, thanks!

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/ebad1dd6ac40

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ebad1dd6ac40