1108198 - Port bug 639134 to TB - ["Allow pages to choose their own colors" does not work with high contrast windows 7 themes]

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Richard Marti (:Paenglab)]

Bug 639134 changed the pref "browser.display.use_document_colors" to "browser.display.document_color_use" and from Boolean to tri-state. Now we need to follow this route.

Comment 1

[Magnus Melin [:mkmelin]]

We'd just put something like into bug 639134 attachment 8529327 [details] [diff] [review] into 
http://mxr.mozilla.org/comm-central/source/mail/base/modules/mailMigrator.js I suppose.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: ChangeColorPref.patch

More or less 1 to 1 port from FX.

And yes I planned to do the migration. :)

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 8532819 [details] [diff] [review]
ChangeColorPref.patch

Review of attachment 8532819 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/preferences/colors.xul
@@ +84,5 @@
> +      <menulist id="useDocumentColors" preference="browser.display.document_color_use">
> +        <menupopup>
> +          <menuitem label="&allowPagesToUseColors.automatic.label;" value="0" id="documentColorAutomatic"/>
> +          <menuitem label="&allowPagesToUseColors.always.label;"    value="1" id="documentColorAlways"/>
> +          <menuitem label="&allowPagesToUseColors.never.label;"     value="2" id="documentColorNever"/>

I guess you just copied if from browser, but it's nicer with the id attr first

::: mail/locales/en-US/chrome/messenger/preferences/colors.dtd
@@ +5,5 @@
>  <!ENTITY  colorsDialog.title              "Colors">
>  <!ENTITY  window.width                    "38em">
>  <!ENTITY  window.macWidth                 "41em">
>  
> +<!ENTITY  allowPagesToUseColors.label           "Allow pages to choose their own colors, instead of my selections above:">

we should probably use "content to choose its own" here, not pages

also I think the "alignment" of entity values should go. As you see even a few lines down in this file, it quickly just becomes a mess.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: ChangeColorPref.patch

Patch with the comments addressed for check-in.

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/ca37edf292be