110820 - Reduce memory allocations when painting thread pane.

Status: VERIFIED FIXED

(MailNews Core :: Database, defect)

Description

[David :Bienvenu]

It turns out that Mork guarantees the yarn it returns will be null terminated,
so we can pass them back as const char *, and the caller doesn't need to copy
them. Patch upcoming.

Comment 1

[David :Bienvenu]

OK, I'm lumping a bunch of changes in this bug. I pruned away some unneeded
members in nsMsgHdr, and did some of the yarn changes I described above. 

Comment 2

[David :Bienvenu]

Attachment: remove some member variables from msghdr and dbfolderinfo

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 58610 [details] [diff] [review]
remove some member variables from msghdr and dbfolderinfo

sr=sspitzer

Comment 4

[David :Bienvenu]

Attachment: remove setisnewsgroup attribute

Comment 5

[Navin Gupta]

r=naving

Comment 6

[David :Bienvenu]

fixed

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Strange, I don't see any difference at all, really.

With the 21-04 Win32 build we have 26,248k (1st run) and 26,300k (second run)
launching mozilla.exe -mail and loading a 1,000 message IMAP Inbox, then scrolling.

On the 26-03 Win32 build we have 26,272 (1st run) and 26,248k (2nd run) using
the same steps.

But looking at the code, it's obvious you removed declarations/inits, so

Verified FIXED.

Comment 8

[David :Bienvenu]

It's really reducing the number of memory allocations - the memory was allocated
and freed right away, so it didn't contribute to bloat; it just slowed us down a
little bit.