1108251 - Review styling for threadpane icons/columns on all platforms

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[alta88]

Some oddities:

1. Cycler column header icons are inconsistent in size, and don't always match the row's icon size.  A simple fix is to make them all 16x16, they probably don't need to be rescaled etc.

2. In grouped by sort view, the dummy header row has a 1px margin-bottom (win and linux), which shrinks the row and clips certain icons in cycler rows.
2b. For subject only, the concept of a dummy header isn't used, so subject is inconsistent with the others.  I think subject should follow the rest; it would mean always returning true here: http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgGroupView.cpp#942

3. Active state behavior (on linux at least) for mousedown on a cycler column header causes the right adjacent column's text to shift.  Ie, if the attachment column is to the immediate left of the subject column.  This could be due to #1.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: MozReview Request: bz://1108251/Paenglab

Comment 2

[Richard Marti (:Paenglab)]

/r/1741 - Bug 1108251 - Fix some threadpane issues. r=josiahone

Pull down this commit:

hg pull review -r fbfb946c53a53af00dda385225109fdbf8329b1e

Comment 3

[Richard Marti (:Paenglab)]

This patch fixes 2. and 3.

1. is okay for me as it is now.
2b. should be done in a other bug.

Comment 4

[Josiah Bruner [:jsbruner]]

Comment on attachment 8541484 [details]
MozReview Request: bz://1108251/Paenglab

https://reviewboard.mozilla.org/r/1739/#review2567

Ship It!

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in

Attaching the patch for easier check-in.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset e742cc8cfe94

Comment 8

[Richard Marti (:Paenglab)]

Attachment: MozReview Request: Bug 1108251 - Fix some threadpane issues. r=josiahone