Give better feedback on reviewer names

NEW
Unassigned

Status

MozReview
General
P3
normal
3 years ago
2 years ago

People

(Reporter: jcranmer, Unassigned)

Tracking

Details

(Reporter)

Description

3 years ago
I wanted to add a Neil as a reviewer. In bugzilla, I normally use neil@parkway (which uniquely autocompletes) as the name. The feedback in reviewboard shows this as Neil+14006, which gives no indication if it's the correct Neil or not. Perhaps these should show the Bugzilla user name strings?
(In reply to Joshua Cranmer [:jcranmer] from comment #0)
> I wanted to add a Neil as a reviewer. In bugzilla, I normally use
> neil@parkway (which uniquely autocompletes) as the name. The feedback in
> reviewboard shows this as Neil+14006, which gives no indication if it's the
> correct Neil or not. Perhaps these should show the Bugzilla user name
> strings?

This is due to Bug 1058786. Review Board uses "username" for display in a lot of places, and if we use the email address we'll be leaking them to anonymous visitors (For why this is a problem see Bug 1058786).

If the bugzilla user has the :<irc-nick> convention in their bugzilla name we will pick that for the RB username. If that fails for any reason (missing, duplicate, etc.) we choose <email-user-before-@>+<bugzilla-id>. So, a workaround for now would be to ask neil to add an :<irc-nick> to his bugzilla name.

All that said, it's possible we could use our extensions to show better information here and we probably should - I don't see this being high priority though, so I wouldn't hold your breath. That being said, I'd be happy to mentor anyone willing to contribute a patch for this.
Depends on: 1058786
(Reporter)

Comment 2

3 years ago
This isn't the email address--it's the username. Neil is weird in that his Bugzilla username is an email address, but it's a different email address than his actual Bugzilla email.

Comment 3

3 years ago
No, Neil is using a (different) email address as real name, not as username.  All usernames are email addresses in Bugzilla, so Bugzilla has built into it the ability to hide usernames from anonymous users.  

Review Board, on the other hand, has separate username and email-address fields but only the ability to hide email addresses.  So if we were to use emails as usernames, as Bugzilla does, we wouldn't be able to hide them from anonymous users.

We had to decide on something to use as the username in Review Board that wasn't the email address.  After some debate we settled on extracting from the :<nick> pattern in the real name, if present, since many regular contributors use this format.  If that doesn't exist, we fall back to the pattern you see above.

We didn't use real names because there are likely many duplicates; since most people actually use the :<nick> pattern to represent their IRC nicks, they are almost certainly unique, for active users at least.  Furthermore, it's not unusual for someone to know another contributor only by irc nick. :)

I fully agree that the reviewer field in MozReview should display real name as well, as smacleod suggests.

Updated

3 years ago
Priority: -- → P2

Comment 4

3 years ago
We have too many P1s, so I'm spreading out the priorities.  P3 -> P4, P2 -> P3, and some portion of P1s will become P2.
Priority: P2 → P3
(Assignee)

Updated

2 years ago
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.