110835 - Rename members of BITMAPINFOHEADER and BITMAPFILEHEADER

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Members of the two mentioned structs should use the same names that Microsoft
uses in its header files.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: Suggested Patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

pavlov, could you please review this patch?

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: Patch that works with latest CVS

Comment 4

[Brian 'netdragon' Bober]

Chris: I am going to include a fix for this bug in my RLE patch. 

Comment 5

[Brian 'netdragon' Bober]

Oh sorry... Therefore its not necessary to review this atm.

Comment 6

[Stuart Parmenter]

Comment on attachment 58523 [details] [diff] [review]
Patch that works with latest CVS

sure.  r=pavlov

Comment 7

[Brian 'netdragon' Bober]

In my patch (I'm still writing) I followed Microsoft's naming convention except
for two things:

1) Instead of BITMAPINFOHEADER I used BitmapInfoHeader to follow the ns coding style
2) replaced DWORDs, BYTEs, and WORDs 

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Marking as dependant on bug 108271, because netdemon's patch for that bug will
fix this one.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

marking as new again

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

reassign to netdemon, since it's his patch in bug 108271 that will fix this bug

Comment 11

[Alfred Kayser]

Is this still valid, or can we mark this one closed by bug 108271?

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

I don't really care about this bug either way, do with it what you want :)

Comment 13

[Alfred Kayser]

Marking fixed by 108271.