1108474 - Let the button to compare revisions scroll with the page

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Design, enhancement)

Description

[Sebastian Zartner [:sebo]]

What problems would this solve?
===============================
The 'COMPARE SELECTED REVISIONS' button at the top of the History page is statically positioned. So people have to scroll up and down between the revisions they want to compare and the button to compare them.

Who would use this?
===================
Editors and reviewers comparing (older) revisions.

What would users see?
=====================
A bar fixed at the top of the page when scrolling containing the button 'COMPARE SELECTED REVISIONS' and the two arrows on the left.

What would users do? What would happen as a result?
===================================================
People would not have to scroll up (or down) anymore after they selected the revisions they want to compare.

Is there anything else we should know?
======================================
This would make the second 'COMPARE SELECTED REVISIONS' button at the bottom of the page redundant, so it should be removed.

Comment 1

[Luke Crouch [:groovecoder]]

IIRC, :openjck did something like this with the EDIT button(s) on the view page. :openjck - I set you as a mentor on this one for a potential volunteer contribution.

Comment 2

[Jamon Camisso [:jamon]]

I've implemented this over in https://github.com/mozilla/kuma/pull/3051 and would welcome any suggestions/review etc.

Comment 3

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/ed3b4c0ce7f00ecbcd1a55ec7eed7b2058696d99
Fixes bug 1108474: Make compare revisions button on history page sticky
Adding bidi-style support for proper ltr/rtl layout of compare button
Tweaked bidi-style to use correct inverse rtl override

https://github.com/mozilla/kuma/commit/d385362da1c5060f4bf8b42fc159aa700e2893bf
Merge pull request #3051 from jamonation/bug-1108474

Fixes bug 1108474: Make compare revisions button on history page sticky

Comment 4

[Sebastian Zartner [:sebo]]

Attachment: Sticky revision control container

Sorry for being picky, though I believe it would be better if not only the button would scroll with the page but it's container <div>. Doing so would avoid the horizontal jump of the button, make it more visible and keep the arrows at the left side of it. Sorry, if my initial description was not clear enough about that.

I attached a mockup of how I'd suspect this to look like.

Comment 5

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.