1108518 - Please remove "English (US)" from the green download button on https://support.mozilla.org/products/firefox

Status: RESOLVED DUPLICATE of bug 1114321

(support.mozilla.org :: General, defect)

Description

[scootergrisen]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045

Steps to reproduce:

In the Help menu i click the Firefox Help link and get this page:
https://support.mozilla.org/da/products/firefox?as=u&utm_source=inproduct


Actual results:

When translating on https://localize.mozilla.org/ i notice that people have just translate this string directly so it says english in all the locales i checked.


Expected results:

Should the string "English (US)" not be changed to something like "Español (CL)"?

And add a comment about it in the translation so people will know not so translate it directly. But altså change the country (language code).

Whats stranger is that if i go to https://support.mozilla.org/ja/products/firefox?as=u&utm_source=inproduct in another browser the website is Japanese, it says English (US) but what i get is the Danish (DA) install file.

Comment 1

[Tim [:pollti]]

Hi :) The button redirects to a locale-free download site, so you'll always get a Danish Fx when visiting the site from Danmark.
The fact, that many localizers directly translated "English (US)" (download buton) in their locale is correct.

Comment 2

[vesper]

Thank you for reporting, scootergrisen!

To avoid confusion with using the source string in other places (where we'll need "English (US)" in other languages, as per pollti's comment), I think it would be best to remove the mention of any locale from that particular UI element - we are redirecting to a localized page where users can choose the download language anyway.

I'm renaming the bug to reflect that suggested workaround.

Comment 3

[Tim [:pollti]]

I think we have to remove line 28 in https://github.com/mozilla/kitsune/blob/3f177c94172c7b9073c30f704ec7689d2ffe3ce8/kitsune/products/templates/products/product.html#L28 and hopefully lines 52 to 60 in https://github.com/mozilla/kitsune/blob/04987977eff950f62da20589e8a3c49a7730c63a/kitsune/sumo/static/less/products.less#L52 (I'm not completely sure, whether this is also used somewhere else).

Comment 4

[Tim [:pollti]]

should we add a locale string to the button added by bug 1117204?

Comment 5

[vesper]

OK, so like mythmon says in https://bugzilla.mozilla.org/show_bug.cgi?id=1114321, we should keep the language information according to the style guide, but change the displayed text from a string to pre-defined text.

Comment 6

[scootergrisen]

Same thing for Thunderbird : https://support.mozilla.org/da/products/thunderbird