Misspelled property name in fte.js

RESOLVED FIXED

Status

Firefox OS
Gaia::Cost Control
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Max Schaefer, Assigned: mai)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
salva
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
On line 206 of js/fte.js (https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/js/fte.js#L206), 'lenght' should be 'length'.
(Assignee)

Updated

3 years ago
Assignee: nobody → marina.rodriguez.iglesias
(Assignee)

Comment 1

3 years ago
Created attachment 8533573 [details] [review]
patch v1.0

Hi Salva,
would you mind reviewing the patch? Typo on the fte viewport initialization.
Attachment #8533573 - Flags: review?(salva)
Comment on attachment 8533573 [details] [review]
patch v1.0

Wow. How is possible this was not failing? Can you provide a regression test with minimum fte coverage in a follow-up, please?

Thank you for fixing!
Attachment #8533573 - Flags: review?(salva) → review+
(Assignee)

Comment 3

3 years ago
Master: 014433e659bd9c7fab8e54cad970eaf493593bf8
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.