1108553 - [e10s] Cannot rotate images in stand-alone image documents using touchpad gestures on Mac - browser-gestureSupport.js is broken in e10s

Status: NEW

(Firefox :: General, defect, P3)

Description

[Christian Sonne [:cers]]

Steps To Reproduce:
1. Open e10s window
2. Go to http://people.mozilla.org/~smartell/blog/20130627/1129-0.png (or any image)
3. Using two fingers on touch pad, initiate rotate gesture

Actual Results:
Nothing happens

Expected Results:
Image should rotate

Comment 2

[Markus Stange [:mstange]]

The problem is probably with these lines:
http://searchfox.org/mozilla-central/rev/d83f1528dbcb1e837d99cf5b6c36a90b03bf0e77/browser/base/content/browser-gestureSupport.js#448-453

We respond to rotate gesture events by setting a transform on the element in the content document. This code is running in the parent process. In e10s mode that doesn't work, instead we'll need to send cross-process messages to do this.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Note that to fix bug 1253892 the gesture in fact needs to be handled in the _parent_ process, not the content one.  It just needs to not throw exceptions due to poking content.*.

So it's not clear to me that fixing this bug will fix that one....

Comment 5

[:Gijs (he/him)]

(In reply to Boris Zbarsky [:bz] from comment #4)
> Note that to fix bug 1253892 the gesture in fact needs to be handled in the
> _parent_ process, not the content one.  It just needs to not throw
> exceptions due to poking content.*.
> 
> So it's not clear to me that fixing this bug will fix that one....

The errors in comment #2 here and in bug 1253892 look basically the same to me. browser-gestureSupport.js needs to not directly access content and send messages to content instead. The handling of the event will probably still happen in the parent, unless there's some reason that's not possible. AIUI that will make both this and bug 1253892 go away.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 8

[Gregory Pappas [:gregp]]

This has been broken for a long time now. Do other browsers support rotating images in standalone image documents? I think we should just remove this dead code