Debug log tab needs a findbar

RESOLVED FIXED in 1.6

Status

Instantbird
Other
--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8533158 [details] [diff] [review]
Patch
Attachment #8533158 - Flags: review?(aleth)
Comment on attachment 8533158 [details] [diff] [review]
Patch

Review of attachment 8533158 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/content/instantbird.xul
@@ +66,5 @@
>      <command id="cmd_textZoomEnlarge" oncommand="if (getBrowser()) FullZoom.enlarge();"/>
>      <command id="cmd_textZoomReset" oncommand="if (getBrowser()) FullZoom.reset();"/>
>      <command id="cmd_find"
> +             oncommand="var panel = getTabBrowser().selectedPanel;
> +                        if (!panel) return;

why isn't this just |if (panel && panel.findbar)| rather than 2 separate tests?
(Assignee)

Comment 2

3 years ago
Because the ampersands need to be escaped, and I figured using two tests is more readable than |if panel &amp;&amp; panel.findbar)|.

Comment 3

3 years ago
Comment on attachment 8533158 [details] [diff] [review]
Patch

Review of attachment 8533158 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with added comment in the panel documentation.

Thanks for fixing this!
Attachment #8533158 - Flags: review?(aleth) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8533167 [details] [diff] [review]
Patch v2

Added the comment.
Attachment #8533158 - Attachment is obsolete: true
Attachment #8533167 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/7d547c917da3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.