Provide mechanism for overriding setting from confvars.sh in mozconfig

RESOLVED WONTFIX

Status

()

--
enhancement
RESOLVED WONTFIX
4 years ago
a month ago

People

(Reporter: jiri.kraml, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141112154212

Steps to reproduce:

I tried to unset a variable defined in mobile/android/confvars.sh (MOZ_NATIVE_DEVICES=1 to be precise) by editing my mozconfig file.


Actual results:

The variable was always evaluated as defined (#ifdef ....)

I tried
mk_add_options MOZ_NATIVE_DEVICES=0
mk_add_options MOZ_NATIVE_DEVICES=
unset MOZ_NATIVE_DEVICES
export MOZ_NATIVE_DEVICES=

What does work is defining a branding folder ("ac_add_options --with-branding=...") and adding "unset unset MOZ_NATIVE_DEVICES" to the configure.sh in that folder
The only way was editing the confvars.sh directly.



Expected results:

There ought to be a way to unset a variable from confvars.sh from mozconfig
(Reporter)

Updated

4 years ago
Severity: normal → enhancement
OS: Linux → All
Hardware: x86_64 → All
Is this something we want to support?
Flags: needinfo?(nalexander)
Flags: needinfo?(mh+mozilla)
(In reply to Kevin Brosnan [:kbrosnan] from comment #1)
> Is this something we want to support?

I don't think this was designed one way or the other.  We do some work in configure.in, then at [1] we include confvars.sh.  I don't know, and a quick DXR doesn't tell me, when the mozconfig is processed.  glandium will know.

I've had to work around the ordering a few times [2], and we might need to do it for MOZ_NATIVE_DEVICES as well; or we can expose a flag for MOZ_NATIVE_DEVICES that is more mozconfig friendly.  I would be happy to take such a flag.

[1] http://dxr.mozilla.org/mozilla-central/source/configure.in#4091

[2] http://dxr.mozilla.org/mozilla-central/source/configure.in#4066
Flags: needinfo?(nalexander)
The current status quo is that things defined in confvars.sh are usually not overridable.
Flags: needinfo?(mh+mozilla)

Updated

a month ago
OS: All → Android
Hardware: All → ARM
I'm going to call this WONTFIX.  I think that mobile/android wants to change things in confvars.sh a little more than other applications, but we're trending away from confvars.sh support and we're not going to support the few things we might override with a general mechanism.
Status: UNCONFIRMED → RESOLVED
Last Resolved: a month ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.