libmozsandbox breaks no-opt B2G build

RESOLVED FIXED in mozilla37

Status

()

Core
Security
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jld, Assigned: jld)

Tracking

Trunk
mozilla37
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
libmozsandbox needs to USE_LIBS mfbt (or maybe mozglue?) because of the symbol dependency on mozilla::unused present on no-optimization builds.

This breaks the B2G no-optimization build, which appears to be very uncommon — this has probably been broken for months (since bug 1059038 landed), and so far only one person has run into it — but it should be fixed.

(Note: the ICS B2G no-opt build is broken both by this and by ICEs in Neon-specific code in libvpx and skia, but bug 1056337 could fix that.)
(Assignee)

Comment 1

3 years ago
Created attachment 8533441 [details] [diff] [review]
bug1108759-noopt-mfbt-hg0.diff

Seems to not break any of the existing builds: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=42599d6539fc
Attachment #8533441 - Flags: review?(mh+mozilla)
(Assignee)

Comment 2

3 years ago
…or maybe this is fallout from bug 1077148, and the correct fix is to change SharedLibrary to GeckoSharedLibrary?
Comment on attachment 8533441 [details] [diff] [review]
bug1108759-noopt-mfbt-hg0.diff

Review of attachment 8533441 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/sandbox/linux/moz.build
@@ +45,5 @@
>          'rt',
>      ]
>  
> +USE_LIBS += [
> +    'mfbt',

make that mozglue, and only in the case you define a SharedLibrary.
Attachment #8533441 - Flags: review?(mh+mozilla) → feedback-
(Assignee)

Comment 4

3 years ago
Created attachment 8533862 [details] [diff] [review]
Patch [v2]
Attachment #8533441 - Attachment is obsolete: true
Attachment #8533862 - Flags: review?(mh+mozilla)
Attachment #8533862 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/dd8ab8e5292d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.