1108781 - Log paths relative to the srcdir, not absolute paths, in xpcshell

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

From our conversation in Portland it seems clear the relpath is what we want in test ids. We can do this pretty easily with the name/path distinction build in by structured logging.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: bz://1108781/chmanchester

Comment 2

[Chris Manchester (limited bugmail, email directly)]

/r/1361 - Bug 1108781 - Log relative paths as test identifiers in xpcshell.;r=ahal

Pull down this commit:

hg pull review -r b94099a50c3c5d84e8ceec6b0daf7115358ece24

Comment 3

[Chris Manchester (limited bugmail, email directly)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8a139e272dbb

Comment 4

[Chris Manchester (limited bugmail, email directly)]

I guess test objects get different keys when running in automation, eh.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

/r/1361 - Bug 1108781 - Log relative paths as test identifiers in xpcshell.;r=ahal

Pull down this commit:

hg pull review -r a0788c19e6aa3634632aad2b80766975b7dc0017

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Try again:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b9d44757a5f0

Comment 7

[Chris Manchester (limited bugmail, email directly)]

/r/1361 - Bug 1108781 - Log relative paths as test identifiers in xpcshell.;r=ahal

Pull down this commit:

hg pull review -r a0788c19e6aa3634632aad2b80766975b7dc0017

Comment 8

[Andrew Halberstadt [:ahal]]

https://reviewboard.mozilla.org/r/1359/#review793

Ship It!

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Attachment: Log relative paths as test identifiers in xpcshell.

r=ahal

Comment 10

[Ed Morley [:emorley]]

Thanks for filing this, would be awesome if we could do this in the other suites too - and also for non-test things like assertion paths (though things like the latter is a longer tail that will take some time to tackle).

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df04db0326a3

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/df04db0326a3

Comment 14

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1108781 - Log relative paths as test identifiers in xpcshell.;r=ahal