Closed
Bug 1108807
Opened 10 years ago
Closed 10 years ago
Rename SIMD.*.shiftLeft to SIMD.*.shiftLeftByScalar
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: sunfish, Assigned: bbouvier)
Details
Attachments
(2 files)
|
9.86 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
|
5.54 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
As of this recent pull request [0], shiftLeft, shiftRightArithmetic, and shiftRightLogical have been renamed to shiftLeftByScalar, shiftRightArithmeticByScalar, and shiftRightLogicalByScalar.
[0] https://github.com/johnmccutchan/ecmascript_simd/pull/87
|
Assignee | |
Comment 1•10 years ago
|
||
Quite easy to do, thanks to all this meta-programming.
Attachment #8533714 -
Flags: review?(till)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → benj
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
And another round of tests grouping.
Attachment #8533716 -
Flags: review?(till)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8533714 [details] [diff] [review]
Rename SIMD shifts
Review of attachment 8533714 [details] [diff] [review]:
-----------------------------------------------------------------
That is indeed delightfully easy.
Attachment #8533714 -
Flags: review?(till) → review+
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8533716 [details] [diff] [review]
Group SIMD.js shift tests
Review of attachment 8533716 [details] [diff] [review]:
-----------------------------------------------------------------
A thing of sheer beauty.
Attachment #8533716 -
Flags: review?(till) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Thanks for the quick review!
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/04a59790e7f2
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/73f9d4bea389
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/04a59790e7f2
https://hg.mozilla.org/mozilla-central/rev/73f9d4bea389
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•