Closed Bug 1108807 Opened 5 years ago Closed 5 years ago

Rename SIMD.*.shiftLeft to SIMD.*.shiftLeftByScalar

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: sunfish, Assigned: bbouvier)

Details

Attachments

(2 files)

As of this recent pull request [0], shiftLeft, shiftRightArithmetic, and shiftRightLogical have been renamed to shiftLeftByScalar, shiftRightArithmeticByScalar, and shiftRightLogicalByScalar.

[0] https://github.com/johnmccutchan/ecmascript_simd/pull/87
Quite easy to do, thanks to all this meta-programming.
Attachment #8533714 - Flags: review?(till)
Assignee: nobody → benj
Status: NEW → ASSIGNED
And another round of tests grouping.
Attachment #8533716 - Flags: review?(till)
Comment on attachment 8533714 [details] [diff] [review]
Rename SIMD shifts

Review of attachment 8533714 [details] [diff] [review]:
-----------------------------------------------------------------

That is indeed delightfully easy.
Attachment #8533714 - Flags: review?(till) → review+
Comment on attachment 8533716 [details] [diff] [review]
Group SIMD.js shift tests

Review of attachment 8533716 [details] [diff] [review]:
-----------------------------------------------------------------

A thing of sheer beauty.
Attachment #8533716 - Flags: review?(till) → review+
https://hg.mozilla.org/mozilla-central/rev/04a59790e7f2
https://hg.mozilla.org/mozilla-central/rev/73f9d4bea389
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.