Closed
Bug 1108810
Opened 11 years ago
Closed 11 years ago
Implement footer for new IA
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bobby, Assigned: akirose)
References
Details
(Whiteboard: [ia][dec12])
Attachments
(2 files)
Design:
- large: https://redpen.io/hsc2386be2e3ff93eb
- small: https://redpen.io/fk3aeecca7291ac443
Details:
- on /, /explore, /tools, /about
- About -> webmaker.org/about
- Teach -> teach.webmaker.org
- Donate -> sendto.mozilla.org
- Blog -> blog.webmaker.org
- Contact -> help@webmaker.org (this one isn't in the design; just add it under Blog)
- Get help -> support.mozilla.org/en-US/products/webmaker
- Privacy -> webmaker.org/privacy
- Legal -> webmaker.org/terms
| Assignee | ||
Comment 1•11 years ago
|
||
| Reporter | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Updated•11 years ago
|
Attachment #8533429 -
Flags: review?(errietta)
Updated•11 years ago
|
Attachment #8533429 -
Flags: review?(errietta) → review+
| Assignee | ||
Comment 3•11 years ago
|
||
I'll leave that final decision up to Matthew
Flags: needinfo?(aki) → needinfo?(mattheww)
Comment 4•11 years ago
|
||
One easy change. Sorry that I posted this to the header IA bug.
Neglected by my comp: In the footer, the CTA and footer nav occupy the same box of soup. To match Ricardo's splash page redesign and anchor the footer nav, let's add:
.navbar-footer {
background:#01527d; /* @lightnavy */
padding-top:1.5em;
}
Beyond that I R+ the footer and hand this over to whoever is on for Quality.
Flags: needinfo?(mattheww)
| Assignee | ||
Comment 5•11 years ago
|
||
Marking this as done as it's been rolled up to the meta-bug #1104272
| Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8536897 -
Flags: review?(gavin)
| Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
| Assignee | ||
Updated•11 years ago
|
Status: REOPENED → ASSIGNED
Comment 7•11 years ago
|
||
Comment on attachment 8536897 [details] [review]
https://github.com/mozilla/webmaker.org/pull/1035
LGTM!
Attachment #8536897 -
Flags: review?(gavin) → review+
| Assignee | ||
Comment 9•11 years ago
|
||
While the footer work isn't done, it's being wrapped up in bug #1111822 so yeah we can close this one.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: needinfo?(aki)
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/b9db7befc7c33a8628a37c7ca9c570221c409e92
Fixes Bug 1108810 - Implement footer for new IA
https://github.com/mozilla/webmaker.org/commit/34b7582d7294d529fa2400fddec62296cc114772
Merge pull request #1035 from gesa/1108810/footer
fixes bug #1108810
https://github.com/mozilla/webmaker.org/commit/5953f30827aca7c225b92896882ea59787f70c88
Fixes Bug 1108810 - Implement footer for new IA
You need to log in
before you can comment on or make changes to this bug.
Description
•