1108825 - OdinMonkey: SIMD.int32x4.mul

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dan Gohman [:sunfish]]

The ecmascript_simd spec includes mul on integer types.

SSE4.1 has PMULLD. On x86 processors which lack SSE4.1, one can shuffle the input values, do two pmuludq instructions, and then shuffle the results to pack the 4 low halves of the result values back into an int32x4 for the output.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Implement SIMD.int32x4.mul in Odin

Finally got it. Sorry the patch is way bigger than expected, but a big part of
it is only code motion. The int32x4.mul needs temporaries if we don't have
SSE4.1, and this condition on lowering makes lowering platform dependent, thus
ReorderCommutative needs to be visible from within the platform-specific
Lowerings, hence the code motion.

I've also added the FPUREG case to movdqa (in Assembler-x86-shared), as it
really doesn't make sense not to be able to copy an Operand to a Register
directly (without looking at the Operand kind).

Comment 2

[Dan Gohman [:sunfish]]

Comment on attachment 8533810 [details] [diff] [review]
Implement SIMD.int32x4.mul in Odin

Review of attachment 8533810 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd24124194d5

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Something's wrong, backed out for SM(e) failures and probably future jit-test failures like https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=dd24124194d5

https://hg.mozilla.org/integration/mozilla-inbound/rev/56d19efedf4f

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

Duh, rebasing conflict with bhackett's patches to make lowering non fallible.

Get in the tree, or die try-ing: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ff8c8871c36c

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

All green, we should be good to go.

https://hg.mozilla.org/integration/mozilla-inbound/rev/354a878fcc9f

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/354a878fcc9f