Closed Bug 1108834 Opened 8 years ago Closed 8 years ago

Add visitSubstr method to none backend

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: stevensn, Assigned: stevensn)

References

Details

Attachments

(2 files, 1 obsolete file)

The visitSubstr method is missing from the Lowering-none(disable-ion) backend.
Add in a stub method for it.
Attached patch visitSubstr.diff (obsolete) — Splinter Review
Attachment #8533405 - Flags: review?(hv1989)
Comment on attachment 8533405 [details] [diff] [review]
visitSubstr.diff

Review of attachment 8533405 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8533405 - Flags: review?(hv1989) → review+
Hi Steve, this patch failed to apply:

renamed 1108834 -> visitSubstr.diff
applying visitSubstr.diff
patching file js/src/jit/none/Lowering-none.h
Hunk #1 FAILED at 83
1 out of 1 hunks FAILED -- saving rejects to file js/src/jit/none/Lowering-none.h.rej

could you take a look, thanks!
Assignee: nobody → steve
Flags: needinfo?(steve)
Keywords: checkin-needed
Attached patch visitSubstr.diffSplinter Review
Patch was bit-rotten by Bug 1107774
Patch refreshed
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8d2e958bf79c
Attachment #8533405 - Attachment is obsolete: true
Flags: needinfo?(steve)
Keywords: checkin-needed
Grr, I didn't fix the bit-rot from bug 1107774 properly the return type needs to change.
Is it easier to have this backed out of inbound or to just do another patch that fixes the return type?
https://hg.mozilla.org/mozilla-central/rev/f91c20c6dc8d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Reopening since the patch just switched one compile error for another
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This patch fixes the return type
Attachment #8535351 - Flags: review?(hv1989)
Attachment #8535351 - Flags: review?(hv1989) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d2d00379a376
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.