1108834 - Add visitSubstr method to none backend

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Steve Singer (:stevensn)]

The visitSubstr method is missing from the Lowering-none(disable-ion) backend.
Add in a stub method for it.

Comment 1

[Steve Singer (:stevensn)]

Attachment: visitSubstr.diff

Comment 2

[Hannes Verschore [:h4writer]]

Comment on attachment 8533405 [details] [diff] [review]
visitSubstr.diff

Review of attachment 8533405 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 3

[Steve Singer (:stevensn)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bc4bb3141b96

Comment 4

[Carsten Book [:Tomcat]]

Hi Steve, this patch failed to apply:

renamed 1108834 -> visitSubstr.diff
applying visitSubstr.diff
patching file js/src/jit/none/Lowering-none.h
Hunk #1 FAILED at 83
1 out of 1 hunks FAILED -- saving rejects to file js/src/jit/none/Lowering-none.h.rej

could you take a look, thanks!

Comment 5

[Steve Singer (:stevensn)]

Attachment: visitSubstr.diff

Patch was bit-rotten by Bug 1107774
Patch refreshed
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8d2e958bf79c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f91c20c6dc8d

Comment 7

[Steve Singer (:stevensn)]

Grr, I didn't fix the bit-rot from bug 1107774 properly the return type needs to change.
Is it easier to have this backed out of inbound or to just do another patch that fixes the return type?

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f91c20c6dc8d

Comment 9

[Steve Singer (:stevensn)]

Reopening since the patch just switched one compile error for another

Comment 10

[Steve Singer (:stevensn)]

Attachment: visitSubstr_void.diff

This patch fixes the return type

Comment 11

[Steve Singer (:stevensn)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dabee4724978

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2d00379a376

Comment 13

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/d2d00379a376