1108846 - generate progress events for resource fetch from MSE

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: notify MediaSourceDecoder of bytes downloaded to trigger progress events

This corresponds to ChannelMediaResource::DoNotifyDataReceived().

I'm not clear on the distinction between NotifyBytesDownloaded() and
NotifyDataArrived(), but I expect they occur at the same time with MSE.

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8533420 [details] [diff] [review]
notify MediaSourceDecoder of bytes downloaded to trigger progress events

Review of attachment 8533420 [details] [diff] [review]:
-----------------------------------------------------------------

NotifyBytesDownloaded and NotifyDataArrived are similar and may be able to be merged with some refactoring.  Right now the intention is for NotifyDataArrived to give the reader read-only access to the data as it's received on the main thread (it was originally added to implement progressive updating of the WebMReader's buffer/time mapping), and NotifyBytesDownloaded to pump the progress event dispatch logic.

It seems slightly cleaner to call mParentDecoder->NotifyBytesDownloaded from TrackBuffer::AppendDataToCurrentResource since NBD and NDA are logically different.

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: notify MediaSourceDecoder of bytes downloaded to trigger progress events v2

This version calls NBD from TrackBuffer::AppendDataToCurrentResource().

The call should be after AppendData() for MediaDecoder::ComputePlaybackRate(),
but I'm not aware of ordering requirements wrt to NDA.

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8533999 [details] [diff] [review]
notify MediaSourceDecoder of bytes downloaded to
trigger progress events v2

Thanks!  There shouldn't be any order dependency between NDA and NBD, so that's good.  Technically, NDA is called before the data is in the MediaCache for ChannelMediaResources whereas here it's called after the data is available, but I don't think (& hope) the users are not dependent on that behaviour difference.

Comment 5

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66c75c0a2312

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66c75c0a2312

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8533999 [details] [diff] [review]
notify MediaSourceDecoder of bytes downloaded to
trigger progress events v2

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Low. Clean change.
[String/UUID change made/needed]: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bcba197a83d7