1108849 - [Dialer] Call log does not update contact name, after adding a new number as a contact

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[[:SalvadorR]]

Description:
Phone number will not update to contact name after adding a new phone number as a contact

Repro Steps:
1) Update a Flame device to BuildID: 20141208040202
2) Have an unknown number call the test device
3) In the Call Log, long press the phone number and create that number as a new contact
4) After updating contact list, close the call log and reopen the dialer app
5) Observe the call log 
  
Actual:
Contact name does not update call log, and phone number still appears
  
Expected: 
Contact name is updated and no longer displays phone number
  
Environmental Variables:
Device: Flame 2.2 Master (319mb) KK Full Flash
BuildID: 20141208040202
Gaia: 0e429d970c160e580e19e61ad8ff5612de159f00
Gecko: c4c7442e9113
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 4/4
Link to failed testcase: https://moztrap.mozilla.org/manage/case/6969/
See attached: Logcat, Video
http://youtu.be/TnDaqdoeLfw

Comment 1

[[:SalvadorR]]

This issue does not occur on Flame 2.1 and Flame 2.0

Results: Contact name updates properly

Flame 2.1

Device: Flame 2.1 (319mb) (Kitkat Base)(Full Flash)
BuildID: 20141205001201
Gaia: 38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko: 8b92c4b8f59a
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Flame 2.0

Device: Flame 2.0 (319mb) (KitKat Base)(Full Flash)
Build ID: 20141208000206
Gaia: 856863962362030174bae4e03d59c3ebbc182473
Gecko: e40fe21e37f1
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 32.0 (2.0)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Broken functionality (regression) on the dialer.

Comment 3

[Chris Kreinbring [:CKreinbring]]

Note:  The best way to repro this bug is to have the number that will be added to a new contact not be at the top of the call log list.

Comment 4

[Chris Kreinbring [:CKreinbring]]

The bug does not repro if the number at the top of the call log is added to a new contact.  
Based on this new information, I was able to repro on Flame 2.1 and Flame 2.0 engineering on shallow flash.
Actual result: Adding a number in the call log that is not the top entry to a new contact will not replace the phone number with the contact name.

Flame 2.1
BuildID: 20141209014645
Gaia: 89421df25ca321f2f4c152dd6e2146cf18b00f06
Gecko: 74fd011aacbf
Platform Version: 34.0
Firmware Version: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0
BuildID: 20141208061237
Gaia: 856863962362030174bae4e03d59c3ebbc182473
Gecko: 2d0860bd0225
Platform Version: 32.0
Firmware Version: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Removing the unnecessary tags.

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: not regression. 
It's pretty ugly we have this defect for several versions. 
Doug can you schedule this to be fixed?

Comment 7

[Doug Sherk (:drs) (inactive)]

Please verify that this is fixed once bug 976990 lands.

Comment 8

[Duane Dixon [:ddixon]]

This bug is a duplicate of bug 976990 and bug 111257--which has been landed and resolved as fixed (in 2.2 and 2.5).  Accordingly, I have verified this bug as fixed in the latest Flame an Aries builds in 2.5 and 2.2.

(Note: Bug 111257 had Depends on bugs: 1141578, 1135044 which have both been verified on their respective branches.) 

Actual Results:  Contact name is updated and no longer displays phone number in the call log.  
     
Repro attempt: 0/15

Environmental Variables:

Device: Flame 2.5 (full flash)
BuildID: 20150819030215
Gaia: 1e1197e0e8e64307aa382ffba4711d1c661de7ca
Gecko: f384789a29dcfd514d25d4a16a97ec5309612d78
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (Master) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.2 (full flash)
BuildID: 20150819032503
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: ebaa55c4247b
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Aries 2.5
Build ID: 20150819130905
Gaia: 8f77edf3ac39d36f6df0f5517223d3ed35ed89e0
Gecko: d590b9601ba8138b621b2553daefd8823ab4295a
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (Master)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0