Remove @target="_blank" from links in the review description

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: MattN, Unassigned)

Tracking

Details

It's generally a bad practice to use @target="_blank" and it messes with my workflow. The option to open a new tab should be left up to the user, not forced by mozreview.

Comment 1

4 years ago
This should be filed against core: https://code.google.com/p/reviewboard/issues
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX

Comment 2

4 years ago
I filed this as https://code.google.com/p/reviewboard/issues/detail?id=3813; on second thought, we'll keep this open as a placeholder until such time as it is fixed upstream.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

Updated

4 years ago
Status: REOPENED → NEW

Comment 3

4 years ago
Upstream says 

We added these because people would sometimes click a link while replying to something or while filling out some field, not pay attention to the warning, and then end up losing content, frustrating them. There were enough requests to add a target="_blank" (and frankly, until now, no feedback to the contrary) that we went ahead and included it.

If we really want it, then, we'll have to do it as an extension.

Comment 4

3 years ago
I understand the complaint here, but I don't think it's worth fixing.
Status: NEW → RESOLVED
Last Resolved: 4 years ago3 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

3 years ago
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.