1108872 - Remove @target="_blank" from links in the review description

Status: RESOLVED WONTFIX

(MozReview Graveyard :: General, defect)

Description

[Matthew N. [:MattN]]

It's generally a bad practice to use @target="_blank" and it messes with my workflow. The option to open a new tab should be left up to the user, not forced by mozreview.

Comment 1

[Mark Côté [:mcote]]

This should be filed against core: https://code.google.com/p/reviewboard/issues

Comment 2

[Mark Côté [:mcote]]

I filed this as https://code.google.com/p/reviewboard/issues/detail?id=3813; on second thought, we'll keep this open as a placeholder until such time as it is fixed upstream.

Comment 3

[Mark Côté [:mcote]]

Upstream says 

We added these because people would sometimes click a link while replying to something or while filling out some field, not pay attention to the warning, and then end up losing content, frustrating them. There were enough requests to add a target="_blank" (and frankly, until now, no feedback to the contrary) that we went ahead and included it.

If we really want it, then, we'll have to do it as an extension.

Comment 4

[Mark Côté [:mcote]]

I understand the complaint here, but I don't think it's worth fixing.