110888 - [rfe]Remove startup check for browser instances

Status: VERIFIED FIXED

(SeaMonkey :: Installer, enhancement)

Description

[Curt Patrick (gone)]

Like bug #110872 for Windows except that Mac is only checking at startup now so
this check has to be moved to the appropriate location rather than removed.

Comment 1

[Syd Logan]

comment here

Comment 2

[Syd Logan]

Attachment: patch to address this

Also in need of checkin is the DLOG, DITL, and cicn resources for the movable
modal window. Also, a str# resource needed to be modified to accomdate the
localizable text displayed in the dialog.

Comment 3

[Samir Gehani]

Comment on attachment 74698 [details] [diff] [review]
patch to address this

r=sgehani  Cool!

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 74698 [details] [diff] [review]
patch to address this

sr=dveditz

Comment 5

[Syd Logan]

adt2 per adt triage

Comment 6

[Syd Logan]

Attachment: sit file with mozilla installer to test (hope this attachment is readable)

unpack the attachment, run the installer. Make sure to have mozilla running at
the same time, and that will cause the check for existing browsers to be made
after the download (or, in the case of a blob install, before unpacking occurs)

Comment 7

[Syd Logan]

Attachment: new test binary (sit file)

ok, grace ran into a problem that was in the trunk. the "is mozilla running"
check is made in a loop, where we find a process with MOZZ or MOZS app type,
and we check to see if it has a vers resource > 4.0. In her tests, and mine, a
vers resource was present, but it was set to 0. So, we looped infinitely,
always finding a moz client, always with a vers resource of 0. So, after
discussing with samir, we decided that the thing that is important is the app
type, which is reserved for mozilla and ns clients, not the version number. So,
I removed the check for the version number, and effectively now it requires you
to exit mozilla or mozilla-based NS clients before the install completes.

Comment 8

[Syd Logan]

By the way, we didn't find this problem testing with the NS client, which has a 
vers resource that is 5.0 or greater. Good job grace for testing against mozilla!

Comment 9

[Grace Bush]

this test build passes- detects both N6 (trunk and 6.2.2) and Mozilla (9.8 and 
current) - after downloading- or before extracting.  
PASS

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 74698 [details] [diff] [review]
patch to address this

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[Syd Logan]

fix checked in

Comment 12

[Daniel Veditz [:dveditz]]

Wait, what about COmmunicator? The reason for the version check was so that a
running Communicator would not block a N6 install. This seemed important to the
MacHeads.

Comment 13

[Grace Bush]

We have been able to keep Communicator open while installing for awhile now.  
Can't pinpoint when that change occurred

Comment 14

[Daniel Veditz [:dveditz]]

That happened around the time the > 4 version check went in :-)  I wanted to
make sure it was still true after this fix went in yesterday since that check
was Apparently removed according to comment 7.

Bad syd, that's a fairly significant change to check in without getting at least
one re-review, I believe Samir or I would have objected.

Comment 15

[Steve Dagley]

Syd did actually ask for my comments on this (via AIM).  The reason the vers #
check needed to be removed is that at some point post 6.0.1 the major vers # of
the Mozilla builds was changed to 0 when it had been 5.  That makes sense in
that the Mozilla builds were declared to be 0.x.x builds but the unfortunate
side effect was that testing for a browser vers # >4 now fails.  The fix was to
either check for vers # >4 || == 0 or not check at all.  I was willing to agree
to the latter. 

Comment 16

[Daniel Veditz [:dveditz]]

But communicator is MOSS while Mozilla is MOZZ, can't the version > 4 check be
limited to the MOSS case, where Netscape 6 will also be > 4?

But OK, if you Mac guys don't mind :-)

Comment 17

[Grace Bush]

verified on 4/1 build

Comment 18

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.