Closed Bug 1108916 Opened 6 years ago Closed 6 years ago

app:// channels could skip calling OnStopRequest

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)

Details

Attachments

(1 file)

appOnStartfix
1.01 KB, patch
u408661
: review+
Details | Diff | Splinter Review
Attached patch appOnStartfix — — Splinter Review 
I missed this when reviewing this code.  Errors returned by the listener from OnStart/OnStop shouldn't exit the function--we need to call both functions and also clean up the loadGroup, etc, even if listeners throw.
Attachment #8533509 - Flags: review?(hurley)
Comment on attachment 8533509 [details] [diff] [review]
appOnStartfix

Review of attachment 8533509 [details] [diff] [review]:
-----------------------------------------------------------------

I'm totally unfamiliar with this code, but based on your description, LGTM :)
Attachment #8533509 - Flags: review?(hurley) → review+
https://hg.mozilla.org/mozilla-central/rev/0f912506c442
Assignee: nobody → jduell.mcbugs
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.