app:// channels could skip calling OnStopRequest

RESOLVED FIXED in mozilla37

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)

Tracking

unspecified
mozilla37
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch appOnStartfixSplinter Review
I missed this when reviewing this code.  Errors returned by the listener from OnStart/OnStop shouldn't exit the function--we need to call both functions and also clean up the loadGroup, etc, even if listeners throw.
Attachment #8533509 - Flags: review?(hurley)
Comment on attachment 8533509 [details] [diff] [review]
appOnStartfix

Review of attachment 8533509 [details] [diff] [review]:
-----------------------------------------------------------------

I'm totally unfamiliar with this code, but based on your description, LGTM :)
Attachment #8533509 - Flags: review?(hurley) → review+
https://hg.mozilla.org/mozilla-central/rev/0f912506c442
Assignee: nobody → jduell.mcbugs
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.