1108994 - Refactor testAddons_installMultipleExtensions from multiple files into a single file

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Daniela Domnici]

Combined two tests from testAddons_installMultipleExtensions into one test.

Comment 1

[Daniela Domnici]

Attachment: patch_V1

Comment 2

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8533647 [details] [diff] [review]
patch_V1

Review of attachment 8533647 [details] [diff] [review]:
-----------------------------------------------------------------

The tests fails intermittently (but most of the times) for me:
ERROR | Test Failure | {
  "exception": {
    "message": "Notification popup state has been opened", 
    "lineNumber": 27, 
    "name": "TimeoutError", 
    "fileName": "resource://mozmill/modules/errors.js"
  }
}

::: firefox/tests/functional/testAddons/testInstallMultipleExtensions.js
@@ +106,5 @@
> +function testCheckMultipleExtensionsAreInstalled() {
> +  addonsManager.open();
> +  addonsManager.setCategory({category: addonsManager.getCategoryById({id: "extension"})});
> +
> +   ADDONS.forEach(function (aAddon) {

There is extra whitespace before ADDONS.forEach

@@ +109,5 @@
> +
> +   ADDONS.forEach(function (aAddon) {
> +
> +    //Verify the addons are installed
> +    var aAddon = addonsManager.getAddons({attribute: "value", value: ADDONS.id})[0];

* aAddon is already used, please choose other variable name
* value: aAddon.id

@@ +110,5 @@
> +   ADDONS.forEach(function (aAddon) {
> +
> +    //Verify the addons are installed
> +    var aAddon = addonsManager.getAddons({attribute: "value", value: ADDONS.id})[0];
> +    var addonIsInstalled = addonsManager.isAddonInstalled({addon: aAddon});

Use the variable defined at previous line instead of aAddon

Comment 3

[Mihaela Velimiroviciu (:mihaelav)]

Also update the commit message and remove [include:testAddons_installMultipleExtensions/manifest.ini] from firefox/tests/functional/restartTests/manifest.ini :)

Comment 4

[Daniela Domnici]

Attachment: patch_V2

updated patch

Comment 5

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8536589 [details] [diff] [review]
patch_V2

Review of attachment 8536589 [details] [diff] [review]:
-----------------------------------------------------------------

Just a couple of small notes...

::: firefox/tests/functional/testAddons/testInstallMultipleExtensions.js
@@ +107,5 @@
> + * Verifies the addons are installed
> + */
> +function testCheckMultipleExtensionsAreInstalled() {
> +  addonsManager.open();
> +  addonsManager.setCategory({category: addonsManager.getCategoryById({id: "extension"})});

It would be better to assign addonsManager.getCategoryById({id: "extension"}) to a variable before you use it.

@@ +108,5 @@
> + */
> +function testCheckMultipleExtensionsAreInstalled() {
> +  addonsManager.open();
> +  addonsManager.setCategory({category: addonsManager.getCategoryById({id: "extension"})});
> +  ADDONS.forEach(function(aAddon) {

You also removed the blank line which was before this, please add it back

Comment 6

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8536589 [details] [diff] [review]
patch_V2

Review of attachment 8536589 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/functional/testAddons/testInstallMultipleExtensions.js
@@ +109,5 @@
> +function testCheckMultipleExtensionsAreInstalled() {
> +  addonsManager.open();
> +  addonsManager.setCategory({category: addonsManager.getCategoryById({id: "extension"})});
> +  ADDONS.forEach(function(aAddon) {
> +    //Verify the addons are installed

Please also add a space here after //

Comment 7

[Daniela Domnici]

Attachment: patch_V3

Updated patch

Comment 8

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8537147 [details] [diff] [review]
patch_V3

Review of attachment 8537147 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/9e4de6c007f8 (default)

Comment 9

[Daniela Domnici]

Attachment: Aurora_installMultipleExtensions_V1

I`ve created a new patch for aurora branch.

Comment 10

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8537678 [details] [diff] [review]
Aurora_installMultipleExtensions_V1

Review of attachment 8537678 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/ab3a4690cf29 (aurora)

Comment 11

[Daniela Domnici]

Attachment: Beta_installMultipleExtensions_V1

I`ve created a new patch for beta branch.

Comment 12

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8537819 [details] [diff] [review]
Beta_installMultipleExtensions_V1

Review of attachment 8537819 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/a152ddb1c07c (beta)

Comment 13

[Andreea Matei [:AndreeaMatei]]

We decided to let these refactoring changes ride the trains.