Closed Bug 1109007 Opened 5 years ago Closed 5 years ago

Add a separated flag for HTML imports

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: gkrizsanits, Assigned: gkrizsanits)

References

Details

Attachments

(1 file)

Since it's likely that we won't ship imports with the rest of web components, we should put it behind its own pref.
Blocks: 1107662
Not sure when will I land this patch but wanted to have it ready.
Comment on attachment 8535613 [details] [diff] [review]
htmlimports.enabled v1

I think it's time to put imports behind its own flag. I don't think certified apps are using it either, so I turned that off as well. Until we decide what to do with the spec I don't think it's worth the time to do any more work on imports for a while than this, but I also don't want it to get in the way.
Attachment #8535613 - Flags: review?(wchen)
Blocks: 1116975
Comment on attachment 8535613 [details] [diff] [review]
htmlimports.enabled v1

Review of attachment 8535613 [details] [diff] [review]:
-----------------------------------------------------------------

Moving imports to its own flag is probably fine given that we've announced that we will not be shipping HTML import in its current form.

https://hacks.mozilla.org/2014/12/mozilla-and-web-components

::: dom/base/nsStyleLinkElement.cpp
@@ +119,5 @@
>    mLineNumber = aLineNumber;
>  }
>  
>  /* static */ bool
>  nsStyleLinkElement::IsImportEnabled(nsIPrincipal* aPrincipal)

This argument isn't used anymore after the changes in this patch.
Attachment #8535613 - Flags: review?(wchen) → review+
Assignee: nobody → gkrizsanits
https://hg.mozilla.org/mozilla-central/rev/9429baa55ac2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.