Closed Bug 1109068 Opened 8 years ago Closed 8 years ago

Expanding/collapsing groups in non-edit mode doesn't animate the background correctly

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-master verified)

VERIFIED FIXED
Tracking Status
b2g-master --- verified

People

(Reporter: cwiiis, Assigned: cwiiis)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

If you expand or collapse a group on the home-screen when not in edit mode, the background jumps to the final position instead of animating smoothly between the two.

This is a regression from adding the shadow to dragging collapsed groups, I think (can't find the bug number...)

Patch incoming.
Style-only change.

For some reason, I was using the 'shadow' element to form the group background in non-edit mode... Using the background element instead fixes the issue and I haven't spotted any regressions.
Attachment #8533711 - Flags: review?(kgrandon)
Blocks: app-grouping
Comment on attachment 8533711 [details] [review]
Fix background animation in non-edit mode

Looks good to me, thanks.
Attachment #8533711 - Flags: review?(kgrandon) → review+
Merged: https://github.com/mozilla-b2g/gaia/commit/043fb13d69494b19576b28e67115fcae041d52e0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Verified fixed on the latest Nightly Flame 3.0 build


Results: app group backgrounds will minimize / maximize smoothly (and all in 1 piece) 

Device: Flame 3.0 (KK - Nightly - Full Flash)
Build ID: 20150209010211
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 3436787a82d0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.