1109071 - linkify mappings on rules page

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Description

[[e-mail] (:bhearsum)]

A common use case for the Balrog UI is to find the rule that matches a query and then inspect its data. Right now, one needs to filter the rules, make note of the release name (mapping), go to the releases page, filter for that name, and view the data. It would be very helpful to have a link from the rules page to the mappings, and maybe even a button that showed the current release blob directly in the rules view.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: linkify mappings on rules page

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8697278 [details] [review]
linkify mappings on rules page

Peter, could you have a look at this? It works fine AFAICT, but I'm unsure about the implementation. I originally tried to use the openDataModal function that's attached to the Releases controller, but I couldn't find a way to make that object accessible. My alternative is to pass in the Releases Service to the Rules Controller, and make a copy of the openDataModal function.

Comment 3

[Peter Bengtsson [:peterbe]]

I dropped some comments in. The truth is that after Thursday I'm taking 2 weeks of PTO. Until then I need to rush to finish a bunch of other important things. So honestly, apart from some quick code review comments I won't have time to dig deeper and be more helpful. Sorry. 

By the way, upgrading balrog-ui to latest angular 1.x and switching to ui-router would make for a great intern or Outreachy project for someone who likes javascript.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 8697278 [details] [review]
linkify mappings on rules page

Jordan, could you do the final review on this? I think we hashed out all the design issues in the PR, settling on always showing the label + small buttons.

Comment 6

[Jordan Lund (:jlund)]

Comment on attachment 8697278 [details] [review]
linkify mappings on rules page

I've never touched the balrog ui. I don't think I'm a candidate to stamp this. I would be interested in getting up to speed on angular and balrog-ui. If you can wait on this, I can look again on this over the holidays.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/6f96532597e3434f9ff06644fd56179261d79691
Pick up latest ui change (bug 1109071).

Comment 8

[[e-mail] (:bhearsum)]

This landed in production today, and looks to be working!

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/c0523568c882fa996e23f1fbcfb1b25c08e5840c
[balrog-ui] Merge pull request #11 from bhearsum/linkify-mappings

bug 1109071: Linkify mapping to populated search of releases page. r=peterbe