Closed Bug 1109073 Opened 5 years ago Closed 5 years ago

Conversation name doesn't get bold in the Loop panel after starting a call

Categories

(Hello (Loop) :: Client, defect, P2)

x86_64
Windows 7
defect
Points:
2

Tracking

(firefox35 fixed, firefox36 fixed, firefox37 fixed)

RESOLVED FIXED
mozilla37
Iteration:
37.1
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: pauly, Unassigned, Mentored)

References

Details

(Whiteboard: [good first verify])

Attachments

(1 file, 2 obsolete files)

Press the "Start a conversation" button so that the call starts in a small window at the bottom of your screen
Actual results:
Conversation name doesn't get bold in the panel, while the Loop icon gets blue
37.0a1 (2014-12-09), Win 7
backlog: --- → Fx35+
Priority: -- → P1
Pauly, Can you retest with Nightly?  

Now that the panel closes automatically when a new conversation is opened, I think this bug is effectively fixed. (When I open the panel after the conversation view is opened, the current (active) conversation is bold in the list as it should be.)
Flags: needinfo?(paul.silaghi)
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #1)
> Pauly, Can you retest with Nightly?  
> 
> Now that the panel closes automatically when a new conversation is opened, I
> think this bug is effectively fixed.
The panel remains open to me after clicking on "start a new conversation"
37.0a1 (2014-12-12) win 7
Flags: needinfo?(paul.silaghi)
I still very much want this in fx35, but I wouldn't block the release on this.
Priority: P1 → P2
Assignee: nobody → nperriault
Blocks: 1074679
There was a bug allowing to have the same room token being listed twice in the roomStore list, making react only using one of the dupes, hence sometimes having obsolete information about it.
Attachment #8538494 - Flags: review?(standard8)
Comment on attachment 8538494 [details] [diff] [review]
Ensure a Loop room entry is highlighted when opened.

Review of attachment 8538494 [details] [diff] [review]:
-----------------------------------------------------------------

Somehow this breaks unit tests:

#getAllRooms
  should order the room list using ctime desc ‣
    AssertionError: expected 1418937570302 to deeply equal 1405518241

I've done a bit of experimentation, I think there's something in the tests that isn't cleaning up. If I run just the #getAllRooms section, then it passes, running the whole file fails.
Attachment #8538494 - Flags: review?(standard8) → review-
(In reply to Mark Banner (:standard8) from comment #5)
> I've done a bit of experimentation, I think there's something in the tests
> that isn't cleaning up.

Fixed.
Attachment #8538494 - Attachment is obsolete: true
Attachment #8539246 - Flags: review?(mdeboer)
Attachment #8539246 - Flags: review?(mdeboer)
As per discussed on IRC, added checks for added room data properties already provided in event data.
Attachment #8539246 - Attachment is obsolete: true
Attachment #8539254 - Flags: review?(mdeboer)
Comment on attachment 8539254 [details] [diff] [review]
Ensure a Loop room entry is highlighted when opened.

Review of attachment 8539254 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!
Attachment #8539254 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/6b6e49450b85
Iteration: --- → 37.1
Points: --- → 2
Target Milestone: --- → mozilla37
Comment on attachment 8539254 [details] [diff] [review]
Ensure a Loop room entry is highlighted when opened.

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Inconsistent notification that someone joined your room (bad)

[Describe test coverage new/current, TBPL]: on fxteam; will merge to m-c soon and I'll verify there.

[Risks and why]: Low - most of the patch is test changes

[String/UUID change made/needed]: none
Attachment #8539254 - Flags: approval-mozilla-beta?
Attachment #8539254 - Flags: approval-mozilla-aurora?
Attachment #8539254 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8539254 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Mentor: anthony.s.hughes
Flags: qe-verify-
Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.