If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Conversation name doesn't get bold in the Loop panel after starting a call

RESOLVED FIXED in Firefox 35

Status

Hello (Loop)
Client
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: pauly, Assigned: NiKo, Mentored)

Tracking

unspecified
mozilla37
x86_64
Windows 7
Points:
2
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed, firefox37 fixed)

Details

(Whiteboard: [good first verify])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

3 years ago
Press the "Start a conversation" button so that the call starts in a small window at the bottom of your screen
Actual results:
Conversation name doesn't get bold in the panel, while the Loop icon gets blue
37.0a1 (2014-12-09), Win 7
backlog: --- → Fx35+
Priority: -- → P1
Pauly, Can you retest with Nightly?  

Now that the panel closes automatically when a new conversation is opened, I think this bug is effectively fixed. (When I open the panel after the conversation view is opened, the current (active) conversation is bold in the list as it should be.)
Flags: needinfo?(paul.silaghi)
(Reporter)

Comment 2

3 years ago
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #1)
> Pauly, Can you retest with Nightly?  
> 
> Now that the panel closes automatically when a new conversation is opened, I
> think this bug is effectively fixed.
The panel remains open to me after clicking on "start a new conversation"
37.0a1 (2014-12-12) win 7
Flags: needinfo?(paul.silaghi)
I still very much want this in fx35, but I wouldn't block the release on this.
Priority: P1 → P2
Assignee: nobody → nperriault
(Reporter)

Updated

3 years ago
Blocks: 1074679
Created attachment 8538494 [details] [diff] [review]
Ensure a Loop room entry is highlighted when opened.

There was a bug allowing to have the same room token being listed twice in the roomStore list, making react only using one of the dupes, hence sometimes having obsolete information about it.
Attachment #8538494 - Flags: review?(standard8)
Comment on attachment 8538494 [details] [diff] [review]
Ensure a Loop room entry is highlighted when opened.

Review of attachment 8538494 [details] [diff] [review]:
-----------------------------------------------------------------

Somehow this breaks unit tests:

#getAllRooms
  should order the room list using ctime desc ‣
    AssertionError: expected 1418937570302 to deeply equal 1405518241

I've done a bit of experimentation, I think there's something in the tests that isn't cleaning up. If I run just the #getAllRooms section, then it passes, running the whole file fails.
Attachment #8538494 - Flags: review?(standard8) → review-
Created attachment 8539246 [details] [diff] [review]
Ensure a Loop room entry is highlighted when opened.

(In reply to Mark Banner (:standard8) from comment #5)
> I've done a bit of experimentation, I think there's something in the tests
> that isn't cleaning up.

Fixed.
Attachment #8538494 - Attachment is obsolete: true
Attachment #8539246 - Flags: review?(mdeboer)
Attachment #8539246 - Flags: review?(mdeboer)
Created attachment 8539254 [details] [diff] [review]
Ensure a Loop room entry is highlighted when opened.

As per discussed on IRC, added checks for added room data properties already provided in event data.
Attachment #8539246 - Attachment is obsolete: true
Attachment #8539254 - Flags: review?(mdeboer)
Comment on attachment 8539254 [details] [diff] [review]
Ensure a Loop room entry is highlighted when opened.

Review of attachment 8539254 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!
Attachment #8539254 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/6b6e49450b85
Iteration: --- → 37.1
Points: --- → 2
Target Milestone: --- → mozilla37

Updated

3 years ago
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
Comment on attachment 8539254 [details] [diff] [review]
Ensure a Loop room entry is highlighted when opened.

Approval Request Comment
[Feature/regressing bug #]: Rooms

[User impact if declined]: Inconsistent notification that someone joined your room (bad)

[Describe test coverage new/current, TBPL]: on fxteam; will merge to m-c soon and I'll verify there.

[Risks and why]: Low - most of the patch is test changes

[String/UUID change made/needed]: none
Attachment #8539254 - Flags: approval-mozilla-beta?
Attachment #8539254 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/6b6e49450b85
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
status-firefox37: affected → fixed
Attachment #8539254 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/084ce7ea8671

Updated

3 years ago
status-firefox36: affected → fixed
Attachment #8539254 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/becd0842dba9

Updated

3 years ago
status-firefox35: affected → fixed
Mentor: anthony.s.hughes@gmail.com
Flags: qe-verify-
Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.