1109114 - Gip mozharness config should have default chunks of 1

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Zac C (:zac)]

The Gip jobs that run in a single go should pass in default values of this-chunk=1 and total-chunks=1.

Comment 1

[Zac C (:zac)]

Attachment: bug_1109114.patch

This will make the buildbot pass in 1 for Gip(a) and Gip(u) suites, and then bug 1092132 can be landed.

Comment 2

[Jonathan Griffin (:jgriffin)]

This would work, but it introduces an idiosyncratic rule that might create some future fragility.  I think it would be better to set this in the mozharness script itself;

if not self.options.total_chunks and (another condition here to see if we're running gaiatest):
   # set total_chunks and this_chunk to 1

Comment 3

[Zac C (:zac)]

OK!

Comment 4

[Zac C (:zac)]

Attachment: bug_1109114.patch

This adds an else statement to set the chunks to 1.

It's already inside an "if gaiatest" block.

Comment 5

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8533830 [details] [diff] [review]
bug_1109114.patch

Review of attachment 8533830 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 6

[Zac C (:zac)]

mgerva, can you push this to mozharness-try so we can test it a bit? Cheers!

Comment 7

[Massimo Gervasini [:massimo]]

Landed to ash-mozharness per irc request:

http://hg.mozilla.org/build/ash-mozharness/rev/f507ac6d4c00

Comment 8

[Zac C (:zac)]

The latest Ash merge commit should be using the ash-mozharness commit above.
https://tbpl.mozilla.org/?tree=Ash&rev=b253f1bb1525

Jgriffin, if everything passes Ok, can it be landed to mozharness?

Comment 9

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8533830 [details] [diff] [review]
bug_1109114.patch

https://hg.mozilla.org/build/mozharness/rev/974ed06d29fb

Comment 10

[Jonathan Griffin (:jgriffin)]

...and pushed to production: https://hg.mozilla.org/build/mozharness/rev/ac749bc6a285

Comment 11

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/mozharness/rev/974ed06d29fb