Gip mozharness config should have default chunks of 1

RESOLVED FIXED

Status

Release Engineering
Applications: MozharnessCore
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: zac, Assigned: zac)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
The Gip jobs that run in a single go should pass in default values of this-chunk=1 and total-chunks=1.
(Assignee)

Comment 1

4 years ago
Created attachment 8533743 [details] [diff] [review]
bug_1109114.patch

This will make the buildbot pass in 1 for Gip(a) and Gip(u) suites, and then bug 1092132 can be landed.
Attachment #8533743 - Flags: review?(jgriffin)
(Assignee)

Updated

4 years ago
Blocks: 1092132
This would work, but it introduces an idiosyncratic rule that might create some future fragility.  I think it would be better to set this in the mozharness script itself;

if not self.options.total_chunks and (another condition here to see if we're running gaiatest):
   # set total_chunks and this_chunk to 1
(Assignee)

Comment 3

4 years ago
OK!
Component: General Automation → Mozharness
QA Contact: catlee → jlund
Summary: Gip buildbot config should pass in default chunks of 1 → Gip mozharness config should have default chunks of 1
(Assignee)

Updated

4 years ago
Attachment #8533743 - Attachment is obsolete: true
Attachment #8533743 - Flags: review?(jgriffin)
(Assignee)

Comment 4

4 years ago
Created attachment 8533830 [details] [diff] [review]
bug_1109114.patch

This adds an else statement to set the chunks to 1.

It's already inside an "if gaiatest" block.
Attachment #8533830 - Flags: review?(jgriffin)
Comment on attachment 8533830 [details] [diff] [review]
bug_1109114.patch

Review of attachment 8533830 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8533830 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 6

4 years ago
mgerva, can you push this to mozharness-try so we can test it a bit? Cheers!
Flags: needinfo?(mgervasini)
Landed to ash-mozharness per irc request:

http://hg.mozilla.org/build/ash-mozharness/rev/f507ac6d4c00
Flags: needinfo?(mgervasini)
(Assignee)

Comment 8

4 years ago
The latest Ash merge commit should be using the ash-mozharness commit above.
https://tbpl.mozilla.org/?tree=Ash&rev=b253f1bb1525

Jgriffin, if everything passes Ok, can it be landed to mozharness?
Flags: needinfo?(jgriffin)
...and pushed to production: https://hg.mozilla.org/build/mozharness/rev/ac749bc6a285
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.