1109137 - When viewing a question, we should let people load more comments

Status: VERIFIED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Anthony Ricaud (:rik)]

Currently, we only display the last 20 comments. We should let people load older comments.

Comment 2

[Anthony Ricaud (:rik)]

This is not a duplicate. bug 1107997 is about loading more questions when displaying a list of questions. This is about loading more comments inside a question.

Comment 3

[Kadir Topal [:atopal]]

UX for this was provided. Anthony would you mind estimating this?

Comment 4

[Kadir Topal [:atopal]]

We actually said this wasn't a blocker.

Comment 5

[Anthony Ricaud (:rik)]

Given that it is not a blocker, I'm not going to spend time estimating this yet. Let's do this after the release.

Comment 6

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla/buddyup/pull/165

Marcia: Could someone test this branch?

Comment 7

[Rehan Dalal (Inactive)]

Comment on attachment 8623750 [details] [review]
https://github.com/mozilla/buddyup/pull/165

one small nit. but looks good. r+

Comment 8

[Marcia Knous [:marcia]]

Attachment: 2015-06-18-13-15-56.png

I tested this a bit with the pull request.

A few comments:

(1) Is the load more button intended to be in the middle/top part of the page? I think in the other screens in BuddyUp it is positioned at the bottom.

(2) In my testing, it seems that the comments all showed even with the Load More button. See the testing thread on staging called "This is a long question again" which has more than 25 entries.

Comment 9

[Anthony Ricaud (:rik)]

https://github.com/mozilla/buddyup/commit/a871b77fc36ceeec1ab19fce7c11acdee8db6da3

About 1), I decided to put it there because I felt it made more sense to the way you read a thread. You want the latest comments visible first and then you might want more context and load previous comments.

About 2), I've checked both threads and they do not display all the comments. The way we display a thread with n comments is this:

Question
Load More
Comment n-20
…
Comment n

When you press load more, we display this:
Questions
Load More
Comment n-40
…
Comment n-21
Comment n-20
…
Comment n

I'm going to go with this and we can always change it later if it's confusing.