Closed Bug 1109235 Opened 5 years ago Closed 5 years ago

remove nsIStreamCipher and implementation

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: keeler, Assigned: retornam, Mentored)

Details

(Whiteboard: [good first bug] )

Attachments

(1 file, 1 obsolete file)

nsIStreamCipher doesn't appear to be used. We can remove it, if so.
Whiteboard: [good first bug][mentor=keeler]
Have you checked extensions?
I did find one extension that uses it, but it's only compatible with Firefox version <= 12, so I think it's safe to remove.
Mentor: dkeeler
Whiteboard: [good first bug][mentor=keeler] → [good first bug]
Assignee: nobody → mozbugs.retornam
Attached patch bug-1109235.patch (obsolete) — Splinter Review
Attachment #8535665 - Flags: review?(dkeeler)
Attachment #8535665 - Attachment is obsolete: true
Attachment #8541807 - Flags: review?(dkeeler)
Comment on attachment 8541807 [details] [diff] [review]
bug-1109235.patch

Review of attachment 8541807 [details] [diff] [review]:
-----------------------------------------------------------------

Great!
Attachment #8541807 - Flags: review?(dkeeler) → review+
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug]
Hi,

can we get a try run for this changes? Thanks!
Flags: needinfo?(mozbugs.retornam)
Keywords: checkin-needed
I went ahead and ran this through try and checked it in. Due to bug 1114669, I also touched CLOBBER to be safe.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eef7c77fc900
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4ddeae5b6c4
Flags: needinfo?(mozbugs.retornam)
https://hg.mozilla.org/mozilla-central/rev/f4ddeae5b6c4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.