If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

remove nsIStreamCipher and implementation

RESOLVED FIXED in mozilla38

Status

()

Core
Security: PSM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: keeler, Assigned: retornam, Mentored)

Tracking

unspecified
mozilla38
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug] )

Attachments

(1 attachment, 1 obsolete attachment)

nsIStreamCipher doesn't appear to be used. We can remove it, if so.
(Reporter)

Updated

3 years ago
Whiteboard: [good first bug][mentor=keeler]
Have you checked extensions?
I did find one extension that uses it, but it's only compatible with Firefox version <= 12, so I think it's safe to remove.
Mentor: dkeeler@mozilla.com
Whiteboard: [good first bug][mentor=keeler] → [good first bug]
(Assignee)

Updated

3 years ago
Assignee: nobody → mozbugs.retornam
(Assignee)

Comment 3

3 years ago
Created attachment 8535665 [details] [diff] [review]
bug-1109235.patch
Attachment #8535665 - Flags: review?(dkeeler)
Comment on attachment 8535665 [details] [diff] [review]
bug-1109235.patch

Review of attachment 8535665 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! However, there are a couple more things to remove. For instance, anything that references nsStreamCipher in nsNSSModule:

http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#34
http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#198
http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#231
http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#263
http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSModule.cpp#300

Also this:

http://dxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/moz.build#61

r- for now.
Attachment #8535665 - Flags: review?(dkeeler) → review-
(Assignee)

Comment 5

3 years ago
Created attachment 8541807 [details] [diff] [review]
bug-1109235.patch
Attachment #8535665 - Attachment is obsolete: true
Attachment #8541807 - Flags: review?(dkeeler)
Comment on attachment 8541807 [details] [diff] [review]
bug-1109235.patch

Review of attachment 8541807 [details] [diff] [review]:
-----------------------------------------------------------------

Great!
Attachment #8541807 - Flags: review?(dkeeler) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug]
Hi,

can we get a try run for this changes? Thanks!
Flags: needinfo?(mozbugs.retornam)
Keywords: checkin-needed
I went ahead and ran this through try and checked it in. Due to bug 1114669, I also touched CLOBBER to be safe.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eef7c77fc900
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4ddeae5b6c4
Flags: needinfo?(mozbugs.retornam)
https://hg.mozilla.org/mozilla-central/rev/f4ddeae5b6c4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.