1109250 - add newsletter signup fields and controls to footer of marketplace

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[David Durst [:ddurst]]

We need to add form fields and controls to the marketplace footer for newsletter subscriptions.

The UX is described in http://people.mozilla.org/~ehunt/newsletter_signup_Nov14/newsletter_v1.8.pdf.

The form fields are:
* name:newsletters; type:hidden; value:(FxOS)?'marketplace':'mozilla-and-you'
* name:source_url; type:hidden
* name:email; type:email (pre-fill if possible)
* name:country; type:select options:2-letter country codes (pre-fill if possible)
* name:lang; type:select; options:2-letter language codes (pre-fill if possible)
* name:privacy; type:checkbox

As there are no controls for these fields, their values are set by default:
* optin=Y
* format=H
* trigger_welcome=Y
* sync -- omitted (optional)

Comment 1

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/fireplace/commit/640df6a5963f9bf6a0deac59fe2dd2594ef7c443

Comment 2

[David Durst [:ddurst]]

Paul -- where can we refer to a canonical list of languages to be used for newsletter subscriptions?

Comment 3

[Paul [:pmac] McLanahan]

It depends on which newsletter to which you'll be subscribing people as some newsletters are more well localized than others. The full list for each newsletter can be had from the data in the newsletters API:

https://basket.mozilla.org/news/newsletters/

This contains data about all newsletters including supported languages.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

"Get Firefox news! Sign up for our newsletter" is missing punctuation:

https://www.dropbox.com/s/i89f0jbmv7tr4dk/Screenshot%202014-12-12%2013.14.05.png?dl=0

––

Focussing the email field or submit button causes the entire section to be re-rendered/re-toggled (even if it's already visible):

https://www.dropbox.com/s/hz290cbe379n8rp/Screenshot%202014-12-12%2013.14.55.png?dl=0

Comment 5

[Mathieu Pillard [:mat]]

> "Get Firefox news! Sign up for our newsletter" is missing punctuation:

Copy in the PDF didn't have a punctuation at the end either, so I didn't know what to do. Do you think there should be a period ?

> Focussing the email field or submit button causes the entire section to be re-rendered/re-toggled (even if it's already visible):

Can you expand on that ? Not sure what you mean.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(In reply to Mathieu Pillard [:mat] from comment #5)
> > "Get Firefox news! Sign up for our newsletter" is missing punctuation:
> 
> Copy in the PDF didn't have a punctuation at the end either, so I didn't
> know what to do. Do you think there should be a period ?

To be honest, I'm not sure. I would probably keep the heading as "Get Firefox news!" and have a sub-heading be "Sign up for our newsletter" (without punctuation). I'll defer to Scott or someone re: punctuation; I'm not an expert with exciting headings!

> > Focussing the email field or submit button causes the entire section to be re-rendered/re-toggled (even if it's already visible):
> 
> Can you expand on that ? Not sure what you mean.

Mark fixed this on Friday: https://github.com/mozilla/fireplace/commit/0d4d6521

Comment 7

[sdevaney]

Well yeah, technically we should have a period at the end of the sentence, so it would read like so:

Get Firefox news! Sign up for our newsletter. 

But actually, the thing that bugs me a bit more is "E-Mail" in the field. That hyphen is pretty 1998, no? Why not just "Email"? However "E-Mail" may be in accord with the broader Mozilla style as established by the brand team?

Comment 8

[Mark Striemer [:mstriemer]]

The photo here is a little out of date. E-Mail has already been switched to Email.

Comment 9

[Victor Carciu]

Verified as fixed . The message is "Get Firefox news! Sign up for our newsletter" I am not sure about the punctuation but it looks good on Marketplace : screencast.com/t/f9y2jBmJzpq