1109252 - Make remaining PSM test cert generation scripts print out cert information as necessary

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

The PSM test cert generation scripts should print out any fingerprints and hashes that tests depend on, so that it's less of a hassle whenever the scripts need to be re-run.

Comment 1

[:Cykesiopka]

Attachment: bug1109252_PSM-cert-gen-print-info_v1.patch

Comment 2

[:Cykesiopka]

(In reply to Cykesiopka from comment #0)
> The PSM test cert generation scripts should print out any fingerprints and
> hashes that tests depend on, so that it's less of a hassle whenever the
> scripts need to be re-run.

Or rather, the scripts that don't already do this should be made to do so.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8533904 [details] [diff] [review]
bug1109252_PSM-cert-gen-print-info_v1.patch

Review of attachment 8533904 [details] [diff] [review]:
-----------------------------------------------------------------

Ok - LGTM.

::: security/manager/ssl/tests/unit/psm_common_py/CertUtils.py
@@ +205,4 @@
>      """
> +    Prints out information (such as fingerprints) for the given cert.
> +    The information printed is sufficient for enabling EV for the given cert
> +    if necessary.

We should probably add something like "The utility 'pp' is available as part of NSS."

::: security/manager/ssl/tests/unit/test_pinning_dynamic/pinning_root_generate.py
@@ +3,2 @@
>  import tempfile, os, sys
>  import random

Some linter is telling me random isn't used in this file anymore, so we should just remove this line.

Comment 4

[:Cykesiopka]

Attachment: bug1109252_PSM-cert-gen-print-info_v2.patch

+ Add note that "The utility 'pp' is available as part of NSS."
+ Remove |import random| (and the three unused imports below it) from pinning_root_generate.py

Comment 5

[:Cykesiopka]

Thanks for the review.

The changes here are NPOTB, but as a sanity check, v1 was part of this try push:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=49be124ab704

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ccd60801cc8

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8ccd60801cc8