Closed
Bug 1109268
Opened 10 years ago
Closed 10 years ago
Add a transition for reveal of filtered jobs
Categories
(Tree Management :: Treeherder, enhancement, P5)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jfrench, Assigned: jfrench)
References
()
Details
Attachments
(2 files)
2.41 KB,
patch
|
Details | Diff | Splinter Review | |
27.89 KB,
image/jpeg
|
Details |
Similar to bug 1098941, camd suggested I open a bug for the possible UI transition for the reveal of filtered jobs.
It doesn't have the same utility and solving the particular user-problem in 1098941, but perhaps there is some benefit to be gained in it.
ie. rather than filtered jobs just popping off, and popping back on, as they presently do. The user will be able to see where in the job block they are appearing.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Just putting up a WIP patch for safe keeping containing the transition, and a shortened job poll just for local testing. Still other issues to investigate.
Assignee | ||
Comment 2•10 years ago
|
||
Some things I'd still like to sort out:
o when a resultset is polled, apply the transition only to new jobs (if any)
o when a resultset is polled, apply a related background transition in the 'total job count' button
The latter which is sort of a new feature on its own I might do in a separate bug. It might be a pretty nice enhancement during polling, particularly when no new jobs are added. Presently there is no feedback in that scenario.
Camd tried out the overall transition/animation effect in a branch and we both agree it adds value, assuming I can sort out the above UX.
Assignee | ||
Comment 3•10 years ago
|
||
I have a draw-order problem caused by this animation effect, on both Firefox and Chrome.
Even though the opacity animation ends at '1' (fully opaque) - all jobs that follow the selected job appear to draw _over the job.
I'm still trying to sort this out.
It would need to be fixed to implement the fade effect proposed.
Otherwise jobs to the right of the selected job appear like they are drawing through the selected job (though really they are drawing over it).
In simple test cases outside of treeherder it doesn't show this problem. The draw order is correct.
Comment 4•10 years ago
|
||
I think this is likely going to be janky perf wise. Also, whilst it would look pretty, I'm not sure it's necessary? ie I think there are better ways to increase discoverability of which jobs are hidden, such as bug 1117561, bug 1117563, bug 1117556.
As such, I'm inclined to wontfix this - jfrench, what do you think?
Assignee | ||
Comment 5•10 years ago
|
||
Ya I was keeping this bug open in the hopes of having time to revisit the draw order issue in comment 3, which I never did. The transition really does look fantastic, it makes Treeherder look orders of magnitude more sophisticated, and I didn't notice any jank. The hope was to use this as a universal behavior when new jobs appear - when they are ingested, or filters are changed which expose them.
For now yes let's mark it wontfix. We always have the transition attached with this bug, so we can grab it if we ever want to resurrect it.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•