1109278 - undocumented Debugger.Script method

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom Tromey :tromey]

The Debugger.Script methods "getAllColumnOffsets" and "isInCatchScope"
are not documented in Debugger.Script.md.

Also, the "strictMode" attribute is documented, but does not seem
to be implemented.

Comment 1

[Tom Tromey :tromey]

"decompile" also seems to be documented but not implemented.

Comment 3

[Jim Blandy :jimb]

Eddy, these are both yours. Will you have any time to take a shot at documenting them?

Comment 4

[Eddy Bruel [:ejpbruel]]

Sure Jim! I'll put it on my todo list for next week.

Comment 5

[Tom Tromey :tromey]

Source.displayURL is also missing

Comment 6

[Jim Blandy :jimb]

(In reply to Tom Tromey :tromey from comment #5)
> Source.displayURL is also missing

I think that one's fitzgen (and my bad review).

Comment 7

[Jim Blandy :jimb]

(In reply to Eddy Bruel [:ejpbruel] from comment #4)
> Sure Jim! I'll put it on my todo list for next week.

Oh, great! Thanks very much.

Comment 8

[Eddy Bruel [:ejpbruel]]

Attachment: Document getAllColumnOffsets and isInCatchScope

Jim, what do you use to view these markdown files? I use a Firefox plugin, but I'm seeing some weird things such as part of the description of getAllOffsets being preformatted while its clearly not intended to be. The markdown I wrote just mimics what we do everywhere else, but that seems wrong somehow.

Comment 9

[Jim Blandy :jimb]

Comment on attachment 8548829 [details] [diff] [review]
Document getAllColumnOffsets and isInCatchScope

Review of attachment 8548829 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, with the point below clarified.

::: js/src/doc/Debugger/Debugger.Script.md
@@ +303,5 @@
>      error.
>  
> +<code>isInCatchScope([<i>offset</i>])</code>
> +:   This is `true` if this offset falls within the scope of a try/catch block,
> +    and `false` otherwise.

Only if it's in the 'try' clause, not the 'catch' clause, right?

Comment 10

[Jim Blandy :jimb]

(In reply to Eddy Bruel [:ejpbruel] from comment #8)
> Created attachment 8548829 [details] [diff] [review]
> Document getAllColumnOffsets and isInCatchScope
> 
> Jim, what do you use to view these markdown files? I use a Firefox plugin,
> but I'm seeing some weird things such as part of the description of
> getAllOffsets being preformatted while its clearly not intended to be. The
> markdown I wrote just mimics what we do everywhere else, but that seems
> wrong somehow.

See the description of 'format.sh' in js/src/doc/README.md. It explains how I check the appearance.

Comment 11

[Eddy Bruel [:ejpbruel]]

https://hg.mozilla.org/integration/fx-team/rev/dfaf13cfe206

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dfaf13cfe206