1109291 - Use relative paths for more addons in BHR

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

We should support addons like LastPass and ADP

Comment 1

[Benjamin Smedberg]

Could you be more specific? Full paths can be a privacy risk and I'd like to review the proposal before this is shipped. The less data we can collect while still answering the necessary questions, the better.

Comment 2

[Roberto Agostino Vitillo (:rvitillo)]

What Jim means with full paths are actually relative paths (e.g. relative to the profile). We are already doing this for filenames in fileIOReports (e.g. {profile}\extensions\[e-mail]\js\bunches\background.js). 

Without the relative paths it's hard to associate a js filename with a specific add-on as there can be clashes with filenames belonging to other add-ons or to our own codebase.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Include better paths for hanging chrome scripts in profile extensions directory (v1)

Right, it's not a full path. For addon scripts in the profile extensions directory (e.g., "file:///home/{user}/.mozilla/firefox/{profile}/extensions/{addon}/components/foo.js"), we want to return "{addon}/components/foo.js" instead of "foo.js".

To do that, we can get the profile path and match that against the script filename, but I think an easier way is to check if the filename contains an "/extensions/" component, and if it does, we extract the part after "/extensions/". I can't think of another case where a chrome script would have "/extensions/" in its path, besides addons scripts under the profile directory, but I could be forgetting something.

Comment 4

[Benjamin Smedberg]

Comment on attachment 8534512 [details] [diff] [review]
Include better paths for hanging chrome scripts in profile extensions directory (v1)

Yes I think this is ok.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55aa832003c1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/55aa832003c1