Closed
Bug 1109325
Opened 9 years ago
Closed 9 years ago
Update Help URL for standalone app
Categories
(Hello (Loop) :: Client, defect, P1)
Tracking
(firefox35 fixed, firefox36 fixed, firefox37 fixed)
backlog | Fx35+ |
People
(Reporter: mreavy, Assigned: rgauthier)
Details
User Story
Change the standalone Help URL to point to https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode so that the standalone user can learn how to respond to a Hello invitation.
Attachments
(1 file)
7.29 KB,
patch
|
NiKo
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1108160#c5, we will change the standalone Help URL to point to https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode . Quoting Joni, "This article works for both link clicker recipients and the Rooms UI (the article will detect the user's version of Firefox and display the appropriate content.)"
Reporter | ||
Updated•9 years ago
|
backlog: --- → Fx35+
Priority: -- → P1
Comment 1•9 years ago
|
||
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #0) > Per https://bugzilla.mozilla.org/show_bug.cgi?id=1108160#c5, we will change > the standalone Help URL to point to > https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode . > > > Quoting Joni, "This article works for both link clicker recipients and the > Rooms UI (the article will detect the user's version of Firefox and display > the appropriate content.)" This can't be right for two reasons: 1) The URL doesn't currently detect the user's version (I just tried this on FF 34 & nightly, both displayed the same content). 2) The support page cannot know which version of Firefox a link was generated on - the standalone page can relate to either calls or rooms, this is determined by the version of Firefox on which the link was *generated*, not the user's version of Firefox. Additionally, the standalone page supports Chrome and other applications, where version detection wouldn't work anyway.
Flags: needinfo?(mreavy)
Flags: needinfo?(jsavage)
Reporter | ||
Comment 2•9 years ago
|
||
I still think it makes sense to change the standalone Help URL to point to https://support.mozilla.org/kb/respond-firefox-hello-invitation-guest-mode , but the content of the page should take into account that the standalone user could be trying to connect with a Fx34 (a call-based model) user or a Fx35-or-later (Rooms-based model) user -- and the standalone user may not be using Firefox. Joni, Mark -- Do you agree? If so, we'll update the standalone help URL in the code per the user story, and Joni will adjust the content of the standalone help page.
User Story: (updated)
Flags: needinfo?(mreavy) → needinfo?(standard8)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rgauthier
Hi, all. The version detector works for me, but Mark brings up good points in comment #1. I've adjusted the content so that users can see both Rooms-based instructions and link-clicker instructions. Is the call-based model going away eventually? When/if that happens, I'll change the article to show only Rooms-based instructions.
Flags: needinfo?(jsavage)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8535017 -
Flags: review?(standard8)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8535017 [details] [diff] [review] Change the help url for standalone Review of attachment 8535017 [details] [diff] [review]: ----------------------------------------------------------------- With Mark on PTO, I think we said during the standup today that Niko would look at this. Niko -- If you have too many review requests, please feel free to redirect them to other peers.
Attachment #8535017 -
Flags: review?(standard8) → review?(nperriault)
Comment on attachment 8535017 [details] [diff] [review] Change the help url for standalone Review of attachment 8535017 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8535017 -
Flags: review?(nperriault) → review+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e47776cc9f88
Iteration: --- → 37.2
Points: --- → 2
Target Milestone: --- → mozilla37
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e47776cc9f88
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 10•9 years ago
|
||
Can someone please nominate this for uplift if this is still blocking Loop in Firefox 35?
Comment 11•9 years ago
|
||
Comment on attachment 8535017 [details] [diff] [review] Change the help url for standalone Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: merge conflicts at most [Describe test coverage new/current, TBPL]: N/A - standalone [Risks and why]: None - standalone [String/UUID change made/needed]: none
Attachment #8535017 -
Flags: approval-mozilla-beta?
Attachment #8535017 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8535017 -
Flags: approval-mozilla-beta?
Attachment #8535017 -
Flags: approval-mozilla-beta+
Attachment #8535017 -
Flags: approval-mozilla-aurora?
Attachment #8535017 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•