1109333 - Selected blackboxed sources in the debugger aren't correctly styled

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

Attachment: Screen Shot 2014-12-09 at 5.53.49 PM.png

Two issues:
* labels are hard to read
* breakpoints should be hidden

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Should backport to aurora too.

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Victor Porof [:vporof][:vp] from comment #1)
> Created attachment 8534001 [details] [diff] [review]
> v1
> 
> Should backport to aurora too.

This goes at least as far back as 34, but yes, we may as well uplift a fix to aurora

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8534001 [details] [diff] [review]
v1

Review of attachment 8534001 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/debugger.inc.css
@@ +99,5 @@
>      -moz-image-region: rect(0px,64px,32px,32px);
>    }
>  }
>  
> +#sources .dbg-source-item.black-boxed {

I think it would work to change just the next other two selectors instead of prepending .dbg-source-item onto each (so this one could be left alone).  Am I missing something here?

@@ +104,4 @@
>    color: rgba(128,128,128,0.4);
>  }
>  
> +#sources .selected .dbg-source-item.black-boxed {

#sources .selected .black-boxed {

@@ +108,4 @@
>    color: rgba(255,255,255,0.4);
>  }
>  
> +#sources .dbg-source-item.black-boxed ~ .dbg-breakpoint {

#sources .black-boxed ~ .dbg-breakpoint {

Comment 4

[Victor Porof [:vporof][:vp]]

(In reply to Brian Grinstead [:bgrins] from comment #3)
> Comment on attachment 8534001 [details] [diff] [review]
> v1
> 

Sure, I just wanted to be more specific.

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v2

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/6588279177dd

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6588279177dd