Closed Bug 1109333 Opened 7 years ago Closed 7 years ago

Selected blackboxed sources in the debugger aren't correctly styled

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(2 files, 1 obsolete file)

Two issues:
* labels are hard to read
* breakpoints should be hidden
Attached patch v1 (obsolete) — Splinter Review
Should backport to aurora too.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8534001 - Flags: review?(bgrinstead)
(In reply to Victor Porof [:vporof][:vp] from comment #1)
> Created attachment 8534001 [details] [diff] [review]
> v1
> 
> Should backport to aurora too.

This goes at least as far back as 34, but yes, we may as well uplift a fix to aurora
Comment on attachment 8534001 [details] [diff] [review]
v1

Review of attachment 8534001 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/debugger.inc.css
@@ +99,5 @@
>      -moz-image-region: rect(0px,64px,32px,32px);
>    }
>  }
>  
> +#sources .dbg-source-item.black-boxed {

I think it would work to change just the next other two selectors instead of prepending .dbg-source-item onto each (so this one could be left alone).  Am I missing something here?

@@ +104,4 @@
>    color: rgba(128,128,128,0.4);
>  }
>  
> +#sources .selected .dbg-source-item.black-boxed {

#sources .selected .black-boxed {

@@ +108,4 @@
>    color: rgba(255,255,255,0.4);
>  }
>  
> +#sources .dbg-source-item.black-boxed ~ .dbg-breakpoint {

#sources .black-boxed ~ .dbg-breakpoint {
Attachment #8534001 - Flags: review?(bgrinstead)
(In reply to Brian Grinstead [:bgrins] from comment #3)
> Comment on attachment 8534001 [details] [diff] [review]
> v1
> 

Sure, I just wanted to be more specific.
Attached patch v2Splinter Review
Attachment #8534001 - Attachment is obsolete: true
Attachment #8534014 - Flags: review?(bgrinstead)
Attachment #8534014 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/6588279177dd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.