Closed Bug 1109372 Opened 7 years ago Closed 7 years ago

Stop using CPOWs for isTabEmpty

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 37

People

(Reporter: billm, Assigned: billm)

References

Details

(Keywords: perf)

Attachments

(1 file, 1 obsolete file)

Attached patch is-empty (obsolete) — Splinter Review
We use a CPOW to access sessionHistory.count. This patch just forwards that information more directly so we don't do any synchronous messaging.
Attachment #8534044 - Flags: review?(felipc)
Can you just use browser.canGoBack || browser.canGoForward?
Keywords: perf
OS: Linux → All
Hardware: x86_64 → All
Version: 34 Branch → Trunk
Comment on attachment 8534044 [details] [diff] [review]
is-empty

That's a good idea. I'll do that.
Attachment #8534044 - Flags: review?(felipc)
Attached patch is-empty v2Splinter Review
Attachment #8534044 - Attachment is obsolete: true
Attachment #8534490 - Flags: review?(dao)
Attachment #8534490 - Flags: review?(dao) → review+
https://hg.mozilla.org/mozilla-central/rev/72893628e91f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
You need to log in before you can comment on or make changes to this bug.