Closed Bug 1109402 Opened 10 years ago Closed 9 years ago

Code move detection can make diff view unnecessarily confusing

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glandium, Unassigned)

Details

See https://reviewboard.mozilla.org/r/967/diff/2/ for example, and how "Moved from/to line 36/48" would be less confusing if they were at the very least aligned. A case could be made that it should handle the "Moved from/to line 41" in a better way as well.
This was a misconfiguration of the Review Board server putting it into a legacy diff generation mode for python. If you look at the diff now it's much nicer and just uses the indentation markers.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.