Closed
Bug 1109453
Opened 10 years ago
Closed 10 years ago
Call WeakMap constructor with "new".
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arai, Unassigned)
References
Details
Attachments
(1 file)
(derived from bug 1108930) Before fixing bug 1062075 and bug 1083752, we need to add "new" to all Map/Set/WeakMap constructor calls. http://dxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/page-worker.js#31 > const views = WeakMap(); > const workers = WeakMap(); > const pages = WeakMap(); http://dxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/system/child_process.js#23 > let processes = WeakMap();
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8534165 -
Flags: review?(rFobic)
|
||
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/4e35c23afa01b945f12d44c9b19bcecef201c9cb Bug 1109453 - Call WeakMap constructor with "new". https://github.com/mozilla/addon-sdk/commit/508b6f1e641c90ea9c7901b04e0944392a8743de Merge pull request #1743 from arai-a/bug1109453 Bug 1109453 - Call WeakMap constructor with "new". r=@gozala
|
||
Updated•10 years ago
|
Attachment #8534165 -
Flags: review?(rFobic) → review+
|
|
Reporter | |
Comment 3•10 years ago
|
||
Thank you for reviewing :) perhaps I need to land same patch to mozilla-central? or it will be merged automatically in near future?
Flags: needinfo?(rFobic)
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?(rFobic)
You need to log in
before you can comment on or make changes to this bug.
Description
•