Closed Bug 1109559 Opened 10 years ago Closed 10 years ago

[Loop] xvfb-run doesn't work on Mac

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: amac, Assigned: amac)

References

Details

Attachments

(1 file)

Change the default value for xvfb
61 bytes, text/x-github-pull-request
jaoo
: review+
Details | Review 
With the change introduced in bug 1109287, on Mac the tests can't run because by default they don't have xvfb installed (and the options are different than the ones in xvfb-run for Linux). So this is just to change the default xvfb value passed to the mocha-slimerjs wrapper.

        Attachment #8534303 -
        Flags: review?(josea.olivera)

    
    

    
  
Comment on attachment 8534303 [details] [review]
Change the default value for xvfb

LGTM. r=me

Left a comment on the pull request. Have a look please. Thanks for taking care of this.

        Attachment #8534303 -
        Flags: review?(josea.olivera) → review+
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → ARM

    
    

    
  
Landed on master at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/677e61ee5423abd96def3925990749ff3fcc1dee
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: