Closed
Bug 1109606
Opened 9 years ago
Closed 9 years ago
Add a test to check that a miss call notification is cleared even if a voicemail notification is present
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Attachments
(2 files)
From the regression seen in bug 1017333 Pre-requisites: Have a voicemail in the notification bar and a missed call notification Repro Steps: 1) Open the notification panel and tap the missed call notification. 2) After the call log appears, drop down the notification panel again. 3) The notification for the call that was just tapped is no longer present.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jlorenzo
QA Whiteboard: [fxosqa-auto-s6][fxosqa-auto-points=3]
Assignee | ||
Updated•9 years ago
|
Summary: Write to test to check that a miss call notification is cleared even if a voicemail notification is present → Add a test to check that a miss call notification is cleared even if a voicemail notification is present
Assignee | ||
Comment 1•9 years ago
|
||
Here's the test I wrote against master. I wanted to test on 2.0 back in the time where the regression was found (https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-central-flame-eng/2014/05/2014-05-27-04-02-02/) but I wasn't able to run marionette present in the 2.0 (or 1.4) branch. So I wanted to try reproducing manually, however the voicemail notification doesn't appear on that branch with my SIM card (from the French carrier called "Free"). Hence, I'm not sure if mocking the voicemail notification could have been enough to catch that regression.
Attachment #8536596 -
Flags: review?(viorela.ioia)
Attachment #8536596 -
Flags: review?(drs.bugzilla)
Comment 2•9 years ago
|
||
Comment on attachment 8536596 [details] [review] Gaia PR I added a couple of comments, and I also want to see the adhoc results of this test run. Besides, all looks good. I'll take a look again shortly.
Attachment #8536596 -
Flags: review?(viorela.ioia) → review-
Comment 3•9 years ago
|
||
Comment on attachment 8536596 [details] [review] Gaia PR Looks good, but I agree with Viorela's comments. r+ with those addressed. One note though about priorities. The issue that this is verifying is already a pretty unimportant edge case, so I think that our time may have been better spent on something else instead. More generally, I think we should still be focusing on making sure that features are working correctly, rather than verifying fixes for edge cases.
Attachment #8536596 -
Flags: review?(drs.bugzilla) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8536596 [details] [review] Gaia PR I change the file name and added the new check at the end of the test. Concerning the priorities, I'm not sure this test is a corner case. Missing somebody calling you and having this person leaving you a message seems like a common use case. What does seem edgy to you Doug?
Attachment #8536596 -
Flags: review- → review?(viorela.ioia)
Comment 5•9 years ago
|
||
Comment on attachment 8536596 [details] [review] Gaia PR Merged in: https://github.com/mozilla-b2g/gaia/commit/939cf033c8cbad4b0864ce463a12f23c3d6fcc84
Attachment #8536596 -
Flags: review?(viorela.ioia) → review+
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 6•9 years ago
|
||
Reverted for JS linter errors as seen on the gaia-try run: https://github.com/mozilla-b2g/gaia/commit/feda5da249dba35afaacbdd0850fe9716aad897c
Status: RESOLVED → REOPENED
Flags: needinfo?(viorela.ioia)
Resolution: FIXED → ---
Comment 7•9 years ago
|
||
Thanks for revert, Kevin, sorry about that! Johan, can you please open a new PR an ask Dave Hunt to review the atom changes? I should have done that in the first place. Thanks!
Flags: needinfo?(viorela.ioia) → needinfo?(jlorenzo)
Assignee | ||
Comment 8•9 years ago
|
||
Thanks Kevin. We may not need to create atoms for 2 times a line of JavaScript. What do you think Dave?
Flags: needinfo?(jlorenzo)
Attachment #8537705 -
Flags: review?(dave.hunt)
Assignee | ||
Comment 9•9 years ago
|
||
Sorry about that, I'll be more careful with the linter in the future.
Comment 10•9 years ago
|
||
Comment on attachment 8537705 [details] [review] Gaia PR - second try Agreed, let's not add to the atoms unless there is a clear benefit.
Attachment #8537705 -
Flags: review?(dave.hunt) → review+
Comment 11•9 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/a7cdad97667823160bb785843e95358b887a5b32
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•