Closed Bug 1109614 Opened 9 years ago Closed 8 years ago

cuechange events not fired for TextTrack with <audio>

Categories

(Core :: Audio/Video: Playback, defect)

34 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: samdutton, Unassigned)

Details

Attachments

(2 files, 3 obsolete files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36

Steps to reproduce:

Open https://simpl.info/track/audio/


Actual results:

Audio plays, no cuechange events, no subtitles displayed.


Expected results:

cuechange events fired, subtitles displayed.

Works for audio and video in Chrome: https://simpl.info/track/audio

Works for video in Firefox: https://simpl.info/t
I can make a reproduction of this situation in Video Element.
cuechange events is not working.
Component: Audio/Video → Audio/Video: Playback
A test to show this isn't working. I also have a patch to make it pass, it hinges on 1033144
Attachment #8714166 - Attachment is obsolete: true
Comment on attachment 8726615 [details] [diff] [review]
Part 1: Add tests for TextTrack cuechange on AudioElement r=rillian

Review of attachment 8726615 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the follow-up. Please set the 'review' flag to '?' and add my email (or another suggested reviewer) when you want review. Just putting r=rillian in the description doesn't flag the patch.
Attachment #8726615 - Flags: review+
Attachment #8726616 - Flags: review+
Green on try.
Backed out for Android 2.3 API9 M(9) failures.

Backouts:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1559ba62821a
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7ded112cb5e

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=395ba8f68dbe
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=23160879&repo=mozilla-inbound
10:59:41     INFO -  3085 INFO TEST-START | dom/media/test/test_texttrackevents_audio.html
11:05:26     INFO -  3086 INFO TEST-UNEXPECTED-FAIL | dom/media/test/test_texttrackevents_audio.html | Test timed out.
11:05:26     INFO -      reportError@SimpleTest/TestRunner.js:114:7
11:05:26     INFO -      TestRunner._checkForHangs@SimpleTest/TestRunner.js:134:7
11:05:26     INFO -  3087 INFO TEST-OK | dom/media/test/test_texttrackevents_audio.html | took 328075ms
Flags: needinfo?(giles)
Skips this test on android 2.3.  I've done some research to look into exactly why this happened and I've not been 100% conclusive, there's a few plausible reasons (like loadedmetadata firing inconsistently).  There is also other that have been intermittently failing with these timeouts around similar functionality (like https://bugzilla.mozilla.org/show_bug.cgi?id=1059116).

I'm keen to work out exactly why this is happening btu I'd really like to see this TextTrack cuechange stuff get into Desktop, so I'm hoping skipping it for Android 2.3 is enough for now?
Attachment #8726615 - Attachment is obsolete: true
Attachment #8733215 - Flags: review?(giles)
Comment on attachment 8733215 [details] [diff] [review]
0001-Bug-1109614-Part-1-Add-tests-for-TextTrack-cuechange.patch

Review of attachment 8733215 [details] [diff] [review]:
-----------------------------------------------------------------

Frustrating, but acceptable for now. Thanks for following up.
Attachment #8733215 - Flags: review?(giles) → review+
Rebase to apply cleanly, add bug reference.
Attachment #8733215 - Attachment is obsolete: true
Flags: needinfo?(giles)
Attachment #8733564 - Flags: review+
Looks like it's not just android.
Flags: needinfo?(giles) → needinfo?(ruxton)
Cheers, will investigate further
Flags: needinfo?(ruxton)
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.