1109692 - Make evaluations that throw faster when an object preview is available

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

When evaluating a scratchpad that throws, we make one or two additional requests to the server to retrieve the exception's properties and displayString. Most of the time however, the required data is present in the evaluateJS response packet as a preview, and the extra requests can be avoided.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Make Scratchpad's evaluations that throw faster

This patch makes writeAsErrorComment use the object preview if available, so that the extra requests are omitted. It also fixes a couple of other minor issues and, more importantly, allows Valence to display stack traces in these cases, as error objects in Chrome don't have properties with location information (file, line, column).

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Make Scratchpad's evaluations that throw faster v2

Removed a redundant check.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8534396 [details] [diff] [review]
Make Scratchpad's evaluations that throw faster v2

Review of attachment 8534396 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/scratchpad/test/browser_scratchpad_eval_func.js
@@ +15,5 @@
>    content.location = "data:text/html;charset=utf8,test Scratchpad eval function.";
>  }
>  
>  function reportErrorAndQuit(error) {
> +  const {DevToolsUtils} = Cu.import("resource://gre/modules/devtools/DevToolsUtils.jsm", {});

Might as well throw this in head.js, its going to be useful in general for many tests. Surprised it's not there already.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/7ff9e2fcc572

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ff9e2fcc572